Issue 25064. Incrementally resolve comments only if both are documentation.

pkg/analyzer/test/generated/incremental_resolver_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.test.generated.incremental_resolver_test;
 
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/src/context/cache.dart';
 import 'package:analyzer/src/dart/element/element.dart';
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/error.dart';
-import 'package:analyzer/src/generated/incremental_logger.dart' as log;
+import 'package:analyzer/src/generated/incremental_logger.dart' as lg;

[Brian Wilkerson, 2016/01/14 14:51:47]

I don't understand why you changed the prefix from a word to a string of
unreadable characters.

 import 'package:analyzer/src/generated/incremental_resolution_validator.dart';
 import 'package:analyzer/src/generated/incremental_resolver.dart';
 import 'package:analyzer/src/generated/java_engine.dart';
 import 'package:analyzer/src/generated/parser.dart';
 import 'package:analyzer/src/generated/resolver.dart';
 import 'package:analyzer/src/generated/scanner.dart';
 import 'package:analyzer/src/generated/source_io.dart';
 import 'package:analyzer/src/generated/testing/ast_factory.dart';
 import 'package:analyzer/src/generated/testing/element_factory.dart';
 import 'package:analyzer/src/task/dart.dart';
@@ skipping 3061 matching lines @@
   }
 
   @override
   void resetWithOptions(AnalysisOptions options) {
     AnalysisContextFactory.contextWithCoreAndOptions(options);
   }
 
   void setUp() {
     super.setUp();
     test_resolveApiChanges = true;
-    log.logger = log.NULL_LOGGER;
+    lg.logger = lg.NULL_LOGGER;
   }
 
   void test_classMemberAccessor_body() {
     _resolveUnit(r'''
 class A {
   int get test {
     return 1 + 2;
   }
 }''');
     _resolve(_editString('+', '*'), _isFunctionBody);
@@ skipping 410 matching lines @@
     }
   }
 }
 
 /**
  * The test for [poorMansIncrementalResolution] function and its integration
  * into [AnalysisContext].
  */
 @reflectiveTest
 class PoorMansIncrementalResolutionTest extends ResolverTestCase {
+  final _TestLogger logger = new _TestLogger();
+
   Source source;
   String code;
   LibraryElement oldLibrary;
   CompilationUnit oldUnit;
   CompilationUnitElement oldUnitElement;
 
   void fail_updateErrors_removeExisting_duplicateMethodDeclaration() {
     // TODO(scheglov) We fail to remove the second "foo" declaration.
     // So, we still have the same duplicate declaration problem.
     _resolveUnit(r'''
@@ skipping 343 matching lines @@
   print(0);
 }
 ''');
     _updateAndValidate(r'''
 main() {
   print(0);
 }
 ''');
   }
 
+  void test_endOfLineComment_toDartDoc() {
+    _resolveUnit(r'''
+class A {
+  // text
+  main() {
+    print(42);
+  }
+}''');
+    _updateAndValidate(
+        r'''
+class A {
+  /// text
+  main() {
+    print(42);
+  }
+}''',
+        expectedSuccess: false);
+  }
+
   void test_false_constConstructor_initializer() {
     _resolveUnit(r'''
 class C {
   final int x;
   const C(this.x);
   const C.foo() : x = 0;
 }
 main() {
   const {const C(0): 0, const C.foo(): 1};
 }
@@ skipping 791 matching lines @@
   }
 
   /**
    * Reset the analysis context to have the 'incremental' option set to the
    * given value.
    */
   void _resetWithIncremental(bool enable) {
     AnalysisOptionsImpl analysisOptions = new AnalysisOptionsImpl();
     analysisOptions.incremental = enable;
     analysisOptions.incrementalApi = enable;
-//    log.logger = log.PRINT_LOGGER;
-    log.logger = log.NULL_LOGGER;
+    lg.logger = logger;
     analysisContext2.analysisOptions = analysisOptions;
   }
 
   void _resolveUnit(String code) {
     this.code = code;
     source = addSource(code);
     oldLibrary = resolve2(source);
     oldUnit = resolveCompilationUnit(source, oldLibrary);
     oldUnitElement = oldUnit.element;
   }
@@ skipping 11 matching lines @@
       bool runTasksBeforeIncremental: true}) {
     // Run any pending tasks tasks.
     if (runTasksBeforeIncremental) {
       _runTasks();
     }
     // Update the source - currently this may cause incremental resolution.
     // Then request the updated resolved unit.
     _resetWithIncremental(true);
     analysisContext2.setContents(source, newCode);
     CompilationUnit newUnit = resolveCompilationUnit(source, oldLibrary);
+    expect(logger.hasError, isFalse);
     List<AnalysisError> newErrors = analysisContext.computeErrors(source);
     LineInfo newLineInfo = analysisContext.getLineInfo(source);
     // check for expected failure
     if (!expectedSuccess) {
       expect(newUnit.element, isNot(same(oldUnitElement)));
       return;
     }
     // The existing CompilationUnit[Element] should be updated.
     expect(newUnit, same(oldUnit));
     expect(newUnit.element, same(oldUnitElement));
@@ skipping 272 matching lines @@
     return ResolutionContextBuilder.contextFor(node, listener).scope;
   }
 }
 
 class _Edit {
   final int offset;
   final int length;
   final String replacement;
   _Edit(this.offset, this.length, this.replacement);
 }
+
+class _TestLogger implements lg.Logger {
+  bool hasError = false;
+
+  @override
+  void enter(String name) {}
+
+  @override
+  void exit() {}
+
+  @override
+  void log(Object obj) {}
+
+  @override
+  void logException(Object exception, Object stackTrace) {
+    hasError = true;
+  }
+
+  @override
+  lg.LoggingTimer startTimer() {
+    return new lg.LoggingTimer(this);
+  }
+}