Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1643)

Unified Diff: docs/closure_compilation.md

Issue 1581253003: Add missing 'hard_dependency' in gyp targets using grit_action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/bluetooth/bluetooth_strings.gyp ('k') | extensions/extensions_resources.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/closure_compilation.md
diff --git a/docs/closure_compilation.md b/docs/closure_compilation.md
index 4f403cdea60bf295a9aa492c6d32dc56a456b869..f4c0a1ce61aea5d2808933674b51629b90351890 100644
--- a/docs/closure_compilation.md
+++ b/docs/closure_compilation.md
@@ -152,6 +152,7 @@ with the contents:
# GN version: //my_project/resources
'target_name': 'my_project_resources',
'type': 'none',
+ 'hard_dependency': 1,
'variables': {
'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/my_project',
'my_file_gen_js': '<(SHARED_INTERMEDIATE_DIR)/closure/my_project/my_file.js',
« no previous file with comments | « device/bluetooth/bluetooth_strings.gyp ('k') | extensions/extensions_resources.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698