Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1581203005: Revert of Make A8 readback work in more cases and improve testing. (Closed)

Created:
4 years, 11 months ago by bsalomon
Modified:
4 years, 11 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@outputswiz
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make A8 readback work in more cases and improve testing. (patchset #5 id:70001 of https://codereview.chromium.org/1584563002/ ) Reason for revert: Breaking video tests in Chrome. Original issue's description: > Make A8 readback work in more cases and improve testing. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1584563002 > > Committed: https://skia.googlesource.com/skia/+/b76afedf11c7fe933954d030048c3222860249e1 TBR=egdaniel@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/23e566664b85472766c921cd2f5615c846919934

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -188 lines) Patch
M src/gpu/gl/GrGLCaps.cpp View 2 chunks +1 line, -27 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 3 chunks +8 lines, -38 lines 0 comments Download
M tests/ReadWriteAlphaTest.cpp View 2 chunks +64 lines, -123 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
bsalomon
Created Revert of Make A8 readback work in more cases and improve testing.
4 years, 11 months ago (2016-01-14 15:19:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581203005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581203005/1
4 years, 11 months ago (2016-01-14 15:19:41 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 15:19:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/23e566664b85472766c921cd2f5615c846919934

Powered by Google App Engine
This is Rietveld 408576698