Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1581143002: Reland of Added unit test for stack traces in telemetry crashes. (Closed)

Created:
4 years, 11 months ago by David Yen
Modified:
4 years, 11 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Added unit test for stack traces in telemetry crashes. (patchset #1 id:1 of https://codereview.chromium.org/1580313002/ ) Reason for revert: Try again disabling 10.6 Original issue's description: > Revert of Added unit test for stack traces in telemetry crashes. (patchset #17 id:320001 of https://codereview.chromium.org/1498633003/ ) > > Reason for revert: > Test fails on some bots. > > Original issue's description: > > Added unit test for stack traces in telemetry crashes. > > > > This CL also fixes an issue on Mac where telemetry does not > > know how to locate chromium_framework for the symbols. > > > > R=nednguyen@google.com > > BUG=563716 > > TEST=ran unit test locally > > > > Committed: https://crrev.com/a20e03ee6906c50bdfaf8fb34fe684b4a89db852 > > Cr-Commit-Position: refs/heads/master@{#368997} > > TBR=nednguyen@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=563716 > > Committed: https://crrev.com/f0cb0bf2dd7f677423318d2318902311e635538d > Cr-Commit-Position: refs/heads/master@{#369056} R=nednguyen@google.com BUG=563716 Committed: https://crrev.com/5f0df0518d4befa6b0c597d0ccdcfa8e50367d00 Cr-Commit-Position: refs/heads/master@{#369404}

Patch Set 1 #

Patch Set 2 : disabled on snow leopard (10.6) #

Total comments: 2

Patch Set 3 : added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
A tools/perf/core/stacktrace_unittest.py View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/exceptions.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py View 1 2 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
David Yen
Created Reland of Added unit test for stack traces in telemetry crashes.
4 years, 11 months ago (2016-01-13 22:01:12 UTC) #1
nednguyen
lgtm
4 years, 11 months ago (2016-01-13 22:07:37 UTC) #3
nednguyen
https://codereview.chromium.org/1581143002/diff/90001/tools/perf/core/stacktrace_unittest.py File tools/perf/core/stacktrace_unittest.py (right): https://codereview.chromium.org/1581143002/diff/90001/tools/perf/core/stacktrace_unittest.py#newcode13 tools/perf/core/stacktrace_unittest.py:13: @decorators.Disabled('snowleopard') nit: add comment why we disable this on ...
4 years, 11 months ago (2016-01-13 22:08:18 UTC) #4
David Yen
https://codereview.chromium.org/1581143002/diff/90001/tools/perf/core/stacktrace_unittest.py File tools/perf/core/stacktrace_unittest.py (right): https://codereview.chromium.org/1581143002/diff/90001/tools/perf/core/stacktrace_unittest.py#newcode13 tools/perf/core/stacktrace_unittest.py:13: @decorators.Disabled('snowleopard') On 2016/01/13 22:08:18, nednguyen wrote: > nit: add ...
4 years, 11 months ago (2016-01-13 22:16:24 UTC) #5
David Yen
On 2016/01/13 22:16:24, David Yen wrote: > https://codereview.chromium.org/1581143002/diff/90001/tools/perf/core/stacktrace_unittest.py > File tools/perf/core/stacktrace_unittest.py (right): > > https://codereview.chromium.org/1581143002/diff/90001/tools/perf/core/stacktrace_unittest.py#newcode13 ...
4 years, 11 months ago (2016-01-14 02:19:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581143002/110001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581143002/110001
4 years, 11 months ago (2016-01-14 02:23:36 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on ...
4 years, 11 months ago (2016-01-14 04:30:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1581143002/110001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1581143002/110001
4 years, 11 months ago (2016-01-14 13:46:15 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:110001)
4 years, 11 months ago (2016-01-14 13:51:00 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 13:52:42 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5f0df0518d4befa6b0c597d0ccdcfa8e50367d00
Cr-Commit-Position: refs/heads/master@{#369404}

Powered by Google App Engine
This is Rietveld 408576698