Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: tools/perf/core/stacktrace_unittest.py

Issue 1581143002: Reland of Added unit test for stack traces in telemetry crashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: disabled on snow leopard (10.6) Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/exceptions.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4
5 from telemetry.core import exceptions
6 from telemetry import decorators
7 from telemetry.testing import tab_test_case
8
9 class TabStackTraceTest(tab_test_case.TabTestCase):
10
11 # For now just work on a single platform (mac).
12 @decorators.Enabled('mac')
13 @decorators.Disabled('snowleopard')
nednguyen 2016/01/13 22:08:18 nit: add comment why we disable this on snowleopar
David Yen 2016/01/13 22:16:23 Done.
14 def testStackTrace(self):
15 try:
16 self._tab.Navigate('chrome://crash', timeout=5)
17 except exceptions.DevtoolsTargetCrashException as e:
18 self.assertIn('Thread 0 (crashed)', '\n'.join(e.stack_trace))
19
20 # Currently stack traces do not work on windows: http://crbug.com/476110
21 # Currently symbols do not work on swarming: http://crbug.com/563716
22 # Linux stack traces depends on fission support: http://crbug.com/405623
23 @decorators.Disabled('all')
24 def testCrashSymbols(self):
25 try:
26 self._tab.Navigate('chrome://crash', timeout=5)
27 except exceptions.DevtoolsTargetCrashException as e:
28 self.assertIn('CrashIntentionally', '\n'.join(e.stack_trace))
OLDNEW
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/exceptions.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698