Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 1581083003: Remove useless std::move(). (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove useless std::move(). https://codereview.chromium.org/1579583004/ converted a Pass() to std::move(), which enabled the compiler to tell us that it's not needed and actually harmful: ..\..\chrome\installer\util\shell_util.cc(277,10) : error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move] return std::move(entries); ^ ..\..\chrome\installer\util\shell_util.cc(277,10) : note: remove std::move call here return std::move(entries); ^~~~~~~~~~ BUG=82385 TBR=mgiuca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/installer/util/shell_util.cc View 2 chunks +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
Nico
4 years, 11 months ago (2016-01-13 15:25:31 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ea48fddb6200ffec6dc01a246f2931baed501505 Cr-Commit-Position: refs/heads/master@{#369176}
4 years, 11 months ago (2016-01-13 15:34:30 UTC) #5
Nico
Committed patchset #1 (id:1) to pending queue manually as 53acfe90cf7e1c06a34f38783256d4c386dd1d16 (presubmit successful).
4 years, 11 months ago (2016-01-13 15:34:33 UTC) #7
Matt Giuca
4 years, 11 months ago (2016-01-13 23:21:21 UTC) #8
Message was sent while issue was closed.
lgtm thanks!

Sorry for breaking Clang Windows.

Powered by Google App Engine
This is Rietveld 408576698