shell_util: Use std::move instead of Pass.

shell_util: Use std::move instead of Pass.

I want to move this code but a presubmit won't let me land code that
uses Pass.

Committed: https://crrev.com/ad4f1d7afb494269fe4ea2aa602c7447d4ca40f8
Cr-Commit-Position: refs/heads/master@{#368987}

[Matt Giuca, 2016-01-12 03:22:33]

mgiuca@chromium.org changed reviewers:
+ gab@chromium.org

[Matt Giuca, 2016-01-12 03:22:33]

Tiny precursor to https://codereview.chromium.org/1578833003/.

[Matt Giuca, 2016-01-12 04:36:00]

Description was changed from

==========
shell_util: Use std::move instead of Pass.

I want to move this code but a presubmit won't let me land code that
uses Pass.
==========

to

==========
shell_util: Use std::move instead of Pass.

I want to move this code but a presubmit won't let me land code that
uses Pass.
==========

[gab, 2016-01-12 20:03:20]

The CQ bit was checked by gab@chromium.org

[gab, 2016-01-12 20:03:20]

lgtm

[commit-bot: I haz the power, 2016-01-12 20:05:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1579583004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1579583004/1

[commit-bot: I haz the power, 2016-01-12 21:19:02]

Description was changed from

==========
shell_util: Use std::move instead of Pass.

I want to move this code but a presubmit won't let me land code that
uses Pass.
==========

to

==========
shell_util: Use std::move instead of Pass.

I want to move this code but a presubmit won't let me land code that
uses Pass.
==========

[commit-bot: I haz the power, 2016-01-12 21:19:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-12 21:20:36]

Description was changed from

==========
shell_util: Use std::move instead of Pass.

I want to move this code but a presubmit won't let me land code that
uses Pass.
==========

to

==========
shell_util: Use std::move instead of Pass.

I want to move this code but a presubmit won't let me land code that
uses Pass.

Committed: https://crrev.com/ad4f1d7afb494269fe4ea2aa602c7447d4ca40f8
Cr-Commit-Position: refs/heads/master@{#368987}
==========

[commit-bot: I haz the power, 2016-01-12 21:20:37]

Patchset 1 (id:??) landed as
https://crrev.com/ad4f1d7afb494269fe4ea2aa602c7447d4ca40f8
Cr-Commit-Position: refs/heads/master@{#368987}

[Nico, 2016-01-13 15:22:41]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-01-13 15:22:42]

immediate pay-off: the compiler can now reason about this.

FAILED: ninja -t msvc -e environment.x86 --
"..\..\third_party/llvm-build/Release+Asserts/bin/clang-cl" -m32 /nologo
/showIncludes /FC @obj\chrome\installer\util\installer_util.shell_util.obj.rsp
/c ..\..\chrome\installer\util\shell_util.cc
/Foobj\chrome\installer\util\installer_util.shell_util.obj
/Fdobj\chrome\installer_util.cc.pdb 
..\..\chrome\installer\util\shell_util.cc(277,10) :  error: moving a local
object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
  return std::move(entries);
         ^
..\..\chrome\installer\util\shell_util.cc(277,10) :  note: remove std::move call
here
  return std::move(entries);
         ^~~~~~~~~~       ~
1 error generated.

I'll send you a CL.