Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1581005: VBoot Reference: Refactoring Part 3 (Closed)

Created:
10 years, 8 months ago by gauravsh
Modified:
9 years, 6 months ago
Reviewers:
Randall Spangler
CC:
chromium-os-reviews_chromium.org, gauravsh
Visibility:
Public.

Description

VBoot Reference: Refactoring Part 3 Refactor and restructure reference code into individual self-contain modules. I have revamped the way the code is structured to make it easy to determine which parts belong in the firmware and which are used by userland tools. common/ - common utilities and stub functions (Firmware) cryptolib/ - crypto library (Firmware) misclibs/ - miscellaneous userland libraries (Userland) sctips/ - Miscellaenous scripts (Userland) tests/ - Tests (Userland) vfirmware/ - Verified Firmware Implementation vfirmware/firmware_image_fw.c (Firmware) vfirmware/firmware_image.c (Userland) vkernel/ - Verified Kernel Implementation vkernel/kernel_image_fw.c (Firmware) vkernel/kernel_image.c (Userland)

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -10 lines) Patch
M src/platform/vboot_reference/Makefile View 1 chunk +5 lines, -3 lines 0 comments Download
M src/platform/vboot_reference/README View 1 chunk +1 line, -1 line 0 comments Download
M src/platform/vboot_reference/common/Makefile View 1 chunk +2 lines, -1 line 0 comments Download
A + src/platform/vboot_reference/common/include/rollback_index.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/common/include/tlcl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/common/include/utility.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/common/rollback_index.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/cryptolib/Makefile View 1 chunk +4 lines, -2 lines 0 comments Download
A + src/platform/vboot_reference/cryptolib/include/cryptolib.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/cryptolib/include/padding.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/cryptolib/include/rsa.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/cryptolib/include/sha.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/cryptolib/padding.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/cryptolib/rsa.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/cryptolib/rsa_utility.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/cryptolib/sha1.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/cryptolib/sha2.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/cryptolib/sha_utility.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A src/platform/vboot_reference/misclibs/Makefile View 1 chunk +24 lines, -0 lines 0 comments Download
A + src/platform/vboot_reference/misclibs/file_keys.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/misclibs/include/file_keys.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/misclibs/include/signature_digest.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/misclibs/signature_digest.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/scripts/genpadding.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/scripts/sign_data.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/platform/vboot_reference/tests/Makefile View 1 chunk +12 lines, -9 lines 0 comments Download
M src/platform/vboot_reference/tests/common.sh View 1 chunk +1 line, -1 line 0 comments Download
A + src/platform/vboot_reference/utility/Makefile View 3 chunks +19 lines, -27 lines 0 comments Download
A + src/platform/vboot_reference/utility/dumpRSAPublicKey.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/utility/firmware_utility.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/utility/include/firmware_utility.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/utility/include/kernel_utility.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/utility/include/verify_data.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/utility/kernel_utility.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/utility/signature_digest_utility.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/utility/verify_data.c View 1 chunk +1 line, -1 line 0 comments Download
A src/platform/vboot_reference/vfirmware/Makefile View 1 chunk +19 lines, -0 lines 0 comments Download
A + src/platform/vboot_reference/vfirmware/firmware_image.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vfirmware/firmware_image_fw.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vfirmware/include/firmware_image.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vfirmware/include/firmware_image_fw.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A src/platform/vboot_reference/vkernel/Makefile View 1 chunk +19 lines, -0 lines 0 comments Download
A + src/platform/vboot_reference/vkernel/include/kernel_image.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vkernel/include/kernel_image_fw.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vkernel/kernel_image.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/platform/vboot_reference/vkernel/kernel_image_fw.c View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gauravsh
10 years, 8 months ago (2010-03-31 06:15:02 UTC) #1
Randall Spangler
10 years, 8 months ago (2010-03-31 17:35:51 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698