Fix the dynamic browser action setIcon path to work with any size icon.

chrome/browser/extensions/extension_action.cc

Index: chrome/browser/extensions/extension_action.cc
diff --git a/chrome/browser/extensions/extension_action.cc b/chrome/browser/extensions/extension_action.cc
index 106ed3a054f125fca3d2f8041c9e3fb307040446..c70cdb5fe120c9e0f1e8142ae416bdde7c037ae0 100644
--- a/chrome/browser/extensions/extension_action.cc
+++ b/chrome/browser/extensions/extension_action.cc
@@ -130,8 +130,10 @@ bool ExtensionAction::ParseIconFromCanvasDictionary(
   for (base::DictionaryValue::Iterator iter(dict); !iter.IsAtEnd();
        iter.Advance()) {
     int icon_size = 0;
-    if (!base::StringToInt(iter.key(), &icon_size))
+    if (!base::StringToInt(iter.key(), &icon_size) || icon_size <= 0 ||
+        icon_size > 1024) {

[Devlin, 2016/01/22 23:41:40]

nit: in your other CL, you use GIGANTOR * 4.  We should use the same limit here
(and probably constify it as something like MaxAllowableIconSize)

[Evan Stade, 2016/01/23 00:03:25]

Admittedly, 1024 is somewhat arbitrary. But why match GIGANGTOR? Extension icons
are not currently related in size to the value for GIGANTOR. They are
EXTENSION_ICON_ACTION. I picked GIGANGTOR*4 as what you'd need for GIGANTOR at
4x scale (which makes sense for product icons). If anything, we should be
limiting this to EXTENSION_ICON_ACTION * 4.

       continue;
+    }
 
     const base::BinaryValue* image_data;
     std::string binary_string64;