Fix the dynamic browser action setIcon path to work with any size icon.

chrome/browser/extensions/extension_action.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_action.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/base64.h"
@@ skipping 112 matching lines @@
 void ExtensionAction::SetIcon(int tab_id, const gfx::Image& image) {
   SetValue(&icon_, tab_id, image);
 }
 
 bool ExtensionAction::ParseIconFromCanvasDictionary(
     const base::DictionaryValue& dict,
     gfx::ImageSkia* icon) {
   for (base::DictionaryValue::Iterator iter(dict); !iter.IsAtEnd();
        iter.Advance()) {
     int icon_size = 0;
-    if (!base::StringToInt(iter.key(), &icon_size))
+    if (!base::StringToInt(iter.key(), &icon_size) || icon_size <= 0 ||
+        icon_size > 1024) {

[Devlin, 2016/01/22 23:41:40]

nit: in your other CL, you use GIGANTOR * 4.  We should use the same limit here
(and probably constify it as something like MaxAllowableIconSize)

[Evan Stade, 2016/01/23 00:03:25]

Admittedly, 1024 is somewhat arbitrary. But why match GIGANGTOR? Extension icons
are not currently related in size to the value for GIGANTOR. They are
EXTENSION_ICON_ACTION. I picked GIGANGTOR*4 as what you'd need for GIGANTOR at
4x scale (which makes sense for product icons). If anything, we should be
limiting this to EXTENSION_ICON_ACTION * 4.

       continue;
+    }
 
     const base::BinaryValue* image_data;
     std::string binary_string64;
     IPC::Message pickle;
     if (iter.value().GetAsBinary(&image_data)) {
       pickle = IPC::Message(image_data->GetBuffer(), image_data->GetSize());
     } else if (iter.value().GetAsString(&binary_string64)) {
       std::string binary_string;
       if (!base::Base64Decode(binary_string64, &binary_string))
         return false;
@@ skipping 179 matching lines @@
   // If there is a default icon, the icon width will be set depending on our
   // action type.
   if (default_icon_)
     return ActionIconSize();
 
   // If no icon has been set and there is no default icon, we need favicon
   // width.
   return ui::ResourceBundle::GetSharedInstance().GetImageNamed(
           IDR_EXTENSIONS_FAVICON).Width();
 }