Ignore key commands in closed windows.

Ignore key commands in closed windows.

BUG=574798
TEST=as in comment 8 in that bug

Committed: https://crrev.com/7f106bf1f5163cee495835ada701d53045a6b6dc
Cr-Commit-Position: refs/heads/master@{#369315}

[Avi (use Gerrit), 2016-01-13 20:15:03]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-13 20:15:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1580943006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1580943006/1

[Avi (use Gerrit), 2016-01-13 20:42:42]

avi@chromium.org changed reviewers:
+ rsesek@chromium.org

[Avi (use Gerrit), 2016-01-13 20:42:42]

I'm too tired to figure out what the correct incantation is to flip internal
NSWindow flag bits... Plus this is real API.

[Robert Sesek, 2016-01-13 21:39:50]

https://codereview.chromium.org/1580943006/diff/1/chrome/browser/ui/cocoa/inf...
File chrome/browser/ui/cocoa/info_bubble_view.mm (right):

https://codereview.chromium.org/1580943006/diff/1/chrome/browser/ui/cocoa/inf...
chrome/browser/ui/cocoa/info_bubble_view.mm:34: // -performKeyEquivalent methods
on all windows in the window list, whether
If this is sent to all windows, why not no-op this in InfoBubbleWindow?

[Avi (use Gerrit), 2016-01-13 21:53:20]

https://codereview.chromium.org/1580943006/diff/1/chrome/browser/ui/cocoa/inf...
File chrome/browser/ui/cocoa/info_bubble_view.mm (right):

https://codereview.chromium.org/1580943006/diff/1/chrome/browser/ui/cocoa/inf...
chrome/browser/ui/cocoa/info_bubble_view.mm:34: // -performKeyEquivalent methods
on all windows in the window list, whether
On 2016/01/13 21:39:50, Robert Sesek wrote:
> If this is sent to all windows, why not no-op this in InfoBubbleWindow?

Because -[NSView performKeyEquivalent] is official API in NSView, while the
NSWindow method involved is -[NSWindow _performKeyEquivalentConditionally:],
which isn't public. If using the public API works, I will take it, even with a
bit of awkwardness, over private calls.

And before you ask, while -[NSResponder performKeyEquivalent] is API too, and
NSWindow subclasses NSResponder, -performKeyEquivalent isn't sent to the window
in this situation, so even though InfoBubbleWindow overrides
-performKeyEquivalent, that's not helpful in this situation.

[Robert Sesek, 2016-01-13 22:17:36]

LGTM

[Avi (use Gerrit), 2016-01-13 22:35:20]

The CQ bit was unchecked by avi@chromium.org

[Avi (use Gerrit), 2016-01-13 22:35:26]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-01-13 22:39:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1580943006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1580943006/1

[commit-bot: I haz the power, 2016-01-13 23:39:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-13 23:39:16]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)

[Avi (use Gerrit), 2016-01-14 03:16:19]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-01-14 03:19:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1580943006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1580943006/1

[commit-bot: I haz the power, 2016-01-14 03:52:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-14 03:53:55]

Description was changed from

==========
Ignore key commands in closed windows.

BUG=574798
TEST=as in comment 8 in that bug
==========

to

==========
Ignore key commands in closed windows.

BUG=574798
TEST=as in comment 8 in that bug

Committed: https://crrev.com/7f106bf1f5163cee495835ada701d53045a6b6dc
Cr-Commit-Position: refs/heads/master@{#369315}
==========

[commit-bot: I haz the power, 2016-01-14 03:53:55]

Patchset 1 (id:??) landed as
https://crrev.com/7f106bf1f5163cee495835ada701d53045a6b6dc
Cr-Commit-Position: refs/heads/master@{#369315}