Ignore key commands in closed windows.

chrome/browser/ui/cocoa/info_bubble_view.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/info_bubble_view.h"
 
 #include "base/logging.h"
+#include "base/mac/foundation_util.h"
+#import "chrome/browser/ui/cocoa/info_bubble_window.h"
 #import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSBezierPath+RoundRect.h"
 
 @implementation InfoBubbleView
 
 @synthesize arrowLocation = arrowLocation_;
 @synthesize alignment = alignment_;
 @synthesize cornerFlags = cornerFlags_;
 
 - (id)initWithFrame:(NSRect)frameRect {
   if ((self = [super initWithFrame:frameRect])) {
     arrowLocation_ = info_bubble::kTopLeft;
     alignment_ = info_bubble::kAlignArrowToAnchor;
     cornerFlags_ = info_bubble::kRoundedAllCorners;
     backgroundColor_.reset([[NSColor whiteColor] retain]);
   }
   return self;
 }
 
+- (BOOL)performKeyEquivalent:(NSEvent *)event {
+  InfoBubbleWindow* info_bubble_window =
+      base::mac::ObjCCast<InfoBubbleWindow>([self window]);
+  if (info_bubble_window && [info_bubble_window isClosing]) {
+    // When a keyboard shortcut is pressed, the method that handles it is
+    // -[NSApplication _handleKeyEquivalent:], which calls the
+    // -performKeyEquivalent methods on all windows in the window list, whether

[Robert Sesek, 2016/01/13 21:39:50]

If this is sent to all windows, why not no-op this in InfoBubbleWindow?

[Avi (use Gerrit), 2016/01/13 21:53:20]

Because -[NSView performKeyEquivalent] is official API in NSView, while the
NSWindow method involved is -[NSWindow _performKeyEquivalentConditionally:],
which isn't public. If using the public API works, I will take it, even with a
bit of awkwardness, over private calls.

And before you ask, while -[NSResponder performKeyEquivalent] is API too, and
NSWindow subclasses NSResponder, -performKeyEquivalent isn't sent to the window
in this situation, so even though InfoBubbleWindow overrides
-performKeyEquivalent, that's not helpful in this situation.

+    // they are open or closed, shown or hidden, active or dying. If a bubble
+    // window is closed but lingers in an autorelease pool, it might receive
+    // unexpected requests for key commands; see <http://crbug.com/574798> for
+    // an example. In such a case, make sure the key equivalent search stops
+    // here rather than proceeding down the view hierarchy and tickling stale
+    // pointers.
+    return NO;
+  }
+  return [super performKeyEquivalent:event];
+}
+
 - (void)drawRect:(NSRect)rect {
   // Make room for the border to be seen.
   NSRect bounds = [self bounds];
   if (arrowLocation_ != info_bubble::kNoArrow) {
     bounds.size.height -= info_bubble::kBubbleArrowHeight;
   }
   rect.size.height -= info_bubble::kBubbleArrowHeight;
 
   float topRadius = cornerFlags_ & info_bubble::kRoundedTopCorners ?
       info_bubble::kBubbleCornerRadius : 0;
@@ skipping 67 matching lines @@
 
 - (NSColor*)backgroundColor {
   return backgroundColor_;
 }
 
 - (void)setBackgroundColor:(NSColor*)backgroundColor {
   backgroundColor_.reset([backgroundColor retain]);
 }
 
 @end