Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2649)

Unified Diff: base/test/test_suite.cc

Issue 1580873003: Enable handle verifier for tests and add some tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add more tests Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/win/scoped_handle.h » ('j') | chrome/app/chrome_main_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/test_suite.cc
diff --git a/base/test/test_suite.cc b/base/test/test_suite.cc
index 82510a20c6b282f9df2ccd804bf1d7a0b4018f38..34e8e118c9f0514a882e195a804dfdcf344cc158 100644
--- a/base/test/test_suite.cc
+++ b/base/test/test_suite.cc
@@ -40,7 +40,10 @@
#endif // OS_IOS
#endif // OS_MACOSX
-#if !defined(OS_WIN)
+#if defined(OS_WIN)
+#include "base/debug/close_handle_hook_win.h"
+#include "base/win/windows_version.h"
+#else
#include "base/i18n/rtl.h"
#if !defined(OS_IOS)
#include "base/strings/string_util.h"
@@ -317,6 +320,14 @@ void TestSuite::Initialize() {
CHECK(debug::EnableInProcessStackDumping());
#if defined(OS_WIN)
+#if defined(_DEBUG)
+ // Handle hooks cause shutdown asserts in Debug on Windows 7. crbug.com/571304
+ if (base::win::GetVersion() >= base::win::VERSION_WIN8)
+ base::debug::InstallHandleHooks();
+#else
+ base::debug::InstallHandleHooks();
+#endif
+
RouteStdioToConsole(true);
// Make sure we run with high resolution timer to minimize differences
// between production code and test code.
« no previous file with comments | « no previous file | base/win/scoped_handle.h » ('j') | chrome/app/chrome_main_delegate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698