chrome/app/chrome_main_delegate.cc - Issue 1580873003: Enable handle verifier for tests and add some tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chrome_main_delegate.cc

Issue 1580873003: Enable handle verifier for tests and add some tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add more tests Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/chrome_main_delegate.cc

diff --git a/chrome/app/chrome_main_delegate.cc b/chrome/app/chrome_main_delegate.cc

index e4fa69afd1d1bb9270ed1a9bc6beca0c7797c2a7..2cbc515c06a18201c65245ac368e8876a6ac0d68 100644

--- a/chrome/app/chrome_main_delegate.cc

+++ b/chrome/app/chrome_main_delegate.cc

@@ -200,7 +200,8 @@ bool UseHooks() {

#elif defined(NDEBUG)

version_info::Channel channel = chrome::GetChannel();

if (channel == version_info::Channel::CANARY ||

- channel == version_info::Channel::DEV) {

+ channel == version_info::Channel::DEV ||

+ channel == version_info::Channel::UNKNOWN) {

cpu_(ooo_6.6-7.5) 2016/01/19 22:53:49 do we need this for the tests?

Will Harris 2016/01/19 23:06:33 AFAIK the bots run on UNKNOWN channel. This is wha

return true;

}

« no previous file with comments | « base/win/scoped_handle_unittest.cc ('k') | no next file » | no next file with comments »