Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1580813005: Whitelist known StrictMode violations to be fixed. (Closed)

Created:
4 years, 11 months ago by Peter Wen
Modified:
4 years, 11 months ago
Reviewers:
Yaron
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, jbudorick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Whitelist known StrictMode violations to be fixed. These are found on bots and since they fail the test when caught we whitelist them and track their fix in bugs. BUG=577168, 577185, 577183, 473357, 577190 Committed: https://crrev.com/826fee194d0e89e159c4d97b1d0b6f1cee5815ee Cr-Commit-Position: refs/heads/master@{#369185}

Patch Set 1 #

Messages

Total messages: 11 (5 generated)
Peter Wen
Hi Yaron, These are existing failures on downstream bots that were caught after turning on ...
4 years, 11 months ago (2016-01-13 15:13:14 UTC) #3
Peter Wen
On 2016/01/13 15:13:14, Peter Wen wrote: > Hi Yaron, > > These are existing failures ...
4 years, 11 months ago (2016-01-13 15:14:16 UTC) #4
Yaron
lgtm
4 years, 11 months ago (2016-01-13 15:56:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580813005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580813005/1
4 years, 11 months ago (2016-01-13 16:01:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-13 16:06:14 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 16:08:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/826fee194d0e89e159c4d97b1d0b6f1cee5815ee
Cr-Commit-Position: refs/heads/master@{#369185}

Powered by Google App Engine
This is Rietveld 408576698