Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java

Issue 1580813005: Whitelist known StrictMode violations to be fixed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java
index 0a324f5cbc0a97bae0088b633f215c72a36fcf56..55ebb0707feee9c24081c7c453bf8b508bab482f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java
@@ -13,6 +13,7 @@ import android.content.res.Resources;
import android.graphics.Bitmap;
import android.net.Uri;
import android.os.Bundle;
+import android.os.StrictMode;
import android.text.Spannable;
import android.text.SpannableStringBuilder;
import android.text.TextUtils;
@@ -487,7 +488,14 @@ public class NotificationUIManager {
}
String platformTag = makePlatformTag(persistentNotificationId, origin, tag);
- mNotificationManager.notify(platformTag, PLATFORM_ID, notificationBuilder.build());
+ // Temporarily allowing disk access. TODO: Fix. See http://crbug.com/577185
+ StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();
+ StrictMode.allowThreadDiskWrites();
+ try {
+ mNotificationManager.notify(platformTag, PLATFORM_ID, notificationBuilder.build());
+ } finally {
+ StrictMode.setThreadPolicy(oldPolicy);
+ }
}
private NotificationBuilder createNotificationBuilder() {

Powered by Google App Engine
This is Rietveld 408576698