Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Unified Diff: xfa/src/fxfa/src/parser/xfa_script_imp.h

Issue 1580773002: Remove dubious cast in CXFA_ScriptContext::AddJSBuiltinObject() (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/src/fxfa/src/parser/xfa_object_imp.cpp ('k') | xfa/src/fxfa/src/parser/xfa_script_imp.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/src/fxfa/src/parser/xfa_script_imp.h
diff --git a/xfa/src/fxfa/src/parser/xfa_script_imp.h b/xfa/src/fxfa/src/parser/xfa_script_imp.h
index 9a1ed6daf23ca79c1b6786d068c85d33e61e9c89..0075c3f68c4958e2905d3d3e0ee218400de2428e 100644
--- a/xfa/src/fxfa/src/parser/xfa_script_imp.h
+++ b/xfa/src/fxfa/src/parser/xfa_script_imp.h
@@ -7,8 +7,7 @@
#ifndef _FXFA_SCRIPT_IMP_H
#define _FXFA_SCRIPT_IMP_H
#define XFA_RESOLVENODE_TagName 0x0002
-#define XFA_JSBUILTIN_Initialized 0x0001
-#define XFA_JSBUILTIN_HasCount 0x0002
+
class CXFA_ResolveProcessor;
class CXFA_ScriptContext : public IXFA_ScriptContext {
public:
@@ -45,7 +44,6 @@ class CXFA_ScriptContext : public IXFA_ScriptContext {
virtual void AddNodesOfRunScript(CXFA_Node* pNode);
virtual FXJSE_HCLASS GetJseNormalClass();
- virtual void AddJSBuiltinObject(XFA_LPCJSBUILTININFO pBuitinObject);
virtual void SetRunAtType(XFA_ATTRIBUTEENUM eRunAt) { m_eRunAtType = eRunAt; }
virtual FX_BOOL IsRunAtClient() {
return m_eRunAtType != XFA_ATTRIBUTEENUM_Server;
@@ -96,6 +94,7 @@ class CXFA_ScriptContext : public IXFA_ScriptContext {
FXJSE_HCONTEXT CreateVariablesContext(CXFA_Node* pScriptNode,
CXFA_Node* pSubform);
void DefineJsClass();
+ void RemoveBuiltInObjs(FXJSE_HCONTEXT jsContext) const;
CXFA_Document* m_pDocument;
FXJSE_HCONTEXT m_hJsContext;
@@ -114,7 +113,6 @@ class CXFA_ScriptContext : public IXFA_ScriptContext {
CXFA_ResolveProcessor* m_pResolveProcessor;
XFA_HFM2JSCONTEXT m_hFM2JSContext;
CXFA_Object* m_pThisObject;
- CFX_CMapByteStringToPtr m_JSBuiltInObjects;
FX_DWORD m_dwBuiltInInFlags;
XFA_ATTRIBUTEENUM m_eRunAtType;
};
« no previous file with comments | « xfa/src/fxfa/src/parser/xfa_object_imp.cpp ('k') | xfa/src/fxfa/src/parser/xfa_script_imp.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698