Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: xfa/src/fxfa/src/parser/xfa_object_imp.cpp

Issue 1580773002: Remove dubious cast in CXFA_ScriptContext::AddJSBuiltinObject() (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/src/fxfa/src/common/xfa_script.h ('k') | xfa/src/fxfa/src/parser/xfa_script_imp.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/src/fxfa/src/parser/xfa_object_imp.cpp
diff --git a/xfa/src/fxfa/src/parser/xfa_object_imp.cpp b/xfa/src/fxfa/src/parser/xfa_object_imp.cpp
index be2bed9334e51609f7422f2c08a067869085dac5..86c267bcc35c9924ddf70ab2efb1087d87849432 100644
--- a/xfa/src/fxfa/src/parser/xfa_object_imp.cpp
+++ b/xfa/src/fxfa/src/parser/xfa_object_imp.cpp
@@ -3967,13 +3967,8 @@ FX_BOOL CXFA_Node::SetCData(XFA_ATTRIBUTE eAttr,
SetUserData(pKey, pClone, &deleteWideStringCallBack);
} else {
SetMapModuleString(pKey, wsValue);
- if (eAttr == XFA_ATTRIBUTE_Name) {
+ if (eAttr == XFA_ATTRIBUTE_Name)
UpdateNameHash();
- if (XFA_LPCJSBUILTININFO pBuiltin =
- XFA_GetJSBuiltinByHash(m_dwNameHash)) {
- m_pDocument->GetScriptContext()->AddJSBuiltinObject(pBuiltin);
- }
- }
}
OnChanged(eAttr, (void*)(const FX_WCHAR*)wsValue, bNotify, bScriptModify);
if (IsNeedSavingXMLNode() && eAttr != XFA_ATTRIBUTE_QualifiedName &&
« no previous file with comments | « xfa/src/fxfa/src/common/xfa_script.h ('k') | xfa/src/fxfa/src/parser/xfa_script_imp.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698