Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1580723003: Gracefully handle proxies in AllCanWrite(). (Closed)

Created:
4 years, 11 months ago by neis
Modified:
4 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Gracefully handle proxies in AllCanWrite(). R=verwaest@chromium.org BUG=chromium:576662, v8:1543 LOG=y Committed: https://crrev.com/863bf39a5f957816fbde9a95d89cdd0a8c662072 Cr-Commit-Position: refs/heads/master@{#33240}

Patch Set 1 #

Patch Set 2 : Add regression test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/harmony/regress/regress-576662.js View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
neis
4 years, 11 months ago (2016-01-12 13:27:57 UTC) #1
Toon Verwaest
what about adding the repro?
4 years, 11 months ago (2016-01-12 13:45:51 UTC) #3
Toon Verwaest
lgtm otherwise
4 years, 11 months ago (2016-01-12 13:46:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580723003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580723003/20001
4 years, 11 months ago (2016-01-12 14:36:49 UTC) #8
neis
On 2016/01/12 13:45:51, Toon Verwaest wrote: > what about adding the repro? done
4 years, 11 months ago (2016-01-12 14:36:59 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-12 14:56:23 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 14:57:03 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/863bf39a5f957816fbde9a95d89cdd0a8c662072
Cr-Commit-Position: refs/heads/master@{#33240}

Powered by Google App Engine
This is Rietveld 408576698