src/objects.cc - Issue 1580723003: Gracefully handle proxies in AllCanWrite().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 1580723003: Gracefully handle proxies in AllCanWrite(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add regression test. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 510e6d3aef46ff963aeea15fe65263258b97402a..e3b8c7d2b93ca6e0df530a700430180617d77bdb 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -1366,7 +1366,7 @@ Maybe<PropertyAttributes> JSObject::GetPropertyAttributesWithFailedAccessCheck(

// static

bool JSObject::AllCanWrite(LookupIterator* it) {

- for (; it->IsFound(); it->Next()) {

+ for (; it->IsFound() && it->state() != LookupIterator::JSPROXY; it->Next()) {

if (it->state() == LookupIterator::ACCESSOR) {

Handle<Object> accessors = it->GetAccessors();

if (accessors->IsAccessorInfo()) {

« no previous file with comments | « no previous file | test/mjsunit/harmony/regress/regress-576662.js » ('j') | no next file with comments »