Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1580673004: Mark mini_installer as chromium_code in gyp builds. (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
gab
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark mini_installer as chromium_code in gyp builds. This matches the gn build. Also fix a warning that only fires in chromium_code mode -- which means that this CL also fixes the clang/win/gn build of mini_installer. BUG=82385 R=gab@chromium.org Committed: https://crrev.com/c4542e5e8b12f32a7fec0cf7ea72cb8d36998751 Cr-Commit-Position: refs/heads/master@{#368983}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/installer/mini_installer.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/mini_installer/mini_installer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Nico
4 years, 11 months ago (2016-01-12 19:54:02 UTC) #2
gab
lgtm
4 years, 11 months ago (2016-01-12 20:17:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580673004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580673004/1
4 years, 11 months ago (2016-01-12 20:28:01 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 20:59:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4542e5e8b12f32a7fec0cf7ea72cb8d36998751
Cr-Commit-Position: refs/heads/master@{#368983}

Powered by Google App Engine
This is Rietveld 408576698