Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1580613002: dart2js: Remove rethrow from the CPS and Tree IRs. (Closed)

Created:
4 years, 11 months ago by Kevin Millikin (Google)
Modified:
4 years, 11 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Restore rethrow to the CPS IR. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -47 lines) Patch
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 1 3 chunks +2 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 5 chunks +0 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Kevin Millikin (Google)
I thought to remove rethrow from the CPS IR too, but it's not so simple ...
4 years, 11 months ago (2016-01-12 16:01:43 UTC) #2
asgerf
lgtm
4 years, 11 months ago (2016-01-12 17:57:44 UTC) #4
Kevin Millikin (Google)
4 years, 11 months ago (2016-01-12 18:49:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1791fb62ded5669311202677ec5ef012bd0c0269 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698