Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart

Issue 1580613002: dart2js: Remove rethrow from the CPS and Tree IRs. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Restore rethrow to the CPS IR. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
index 75963215a4f50a674554e7df0d609befeb0bb4bd..b846c878c13e974f1ace9bec719c3024621652a2 100644
--- a/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
@@ -410,10 +410,6 @@ class Builder implements cps_ir.Visitor/*<NodeCallback|Node>*/ {
return new Throw(value);
}
- Statement visitRethrow(cps_ir.Rethrow node) {
- return new Rethrow();
- }
-
Statement visitUnreachable(cps_ir.Unreachable node) {
return new Unreachable();
}
@@ -744,11 +740,6 @@ class Builder implements cps_ir.Visitor/*<NodeCallback|Node>*/ {
return (Statement next) => next; // Compile to nothing.
}
- @override
- Expression visitBoundsCheck(cps_ir.BoundsCheck node) {
- throw 'Unexpected BoundsCheck node in tree builder';
- }
-
/********** UNUSED VISIT METHODS *************/
unexpectedNode(cps_ir.Node node) {
@@ -761,4 +752,6 @@ class Builder implements cps_ir.Visitor/*<NodeCallback|Node>*/ {
visitParameter(cps_ir.Parameter node) => unexpectedNode(node);
visitContinuation(cps_ir.Continuation node) => unexpectedNode(node);
visitMutableVariable(cps_ir.MutableVariable node) => unexpectedNode(node);
+ visitRethrow(cps_ir.Rethrow node) => unexpectedNode(node);
+ visitBoundsCheck(cps_ir.BoundsCheck node) => unexpectedNode(node);
}
« no previous file with comments | « pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart ('k') | pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698