Issue 15806014: Reduce usage of WebString::data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15806014: Reduce usage of WebString::data (Closed)

Created:
7 years, 6 months ago by abarth-chromium

Modified:
7 years, 6 months ago

Reviewers:
jamesr

CC:
blink-reviews, kinuko, jeez, eae+blinkwatch, jochen+watch_chromium.org, eseidel

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Reduce usage of WebString::data WebString::data forces a widening of the underlying String from 8 bits to 16 bits. We should remove this function because most callers of the API don't understand these implementation details of WebString. In order to remove the API, we need to remove all the callers. This CL removes all the callers I could find in Blink. The next CL will sweep across Chromium. R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151268

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -7 lines)			Patch
M	Source/WebKit/chromium/src/WebBindings.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/WebKit/chromium/src/WorkerFileSystemCallbacksBridge.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/platform/chromium/support/WebString.cpp	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Tools/DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	public/platform/WebString.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/15806014/1

7 years, 6 months ago (2013-05-28 17:06:28 UTC) #5

abarth-chromium

7 years, 6 months ago (2013-05-28 17:14:39 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r151268 (presubmit successful).

Expand Messages | Collapse Messages