Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp - Issue 15806014: Reduce usage of WebString::data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp

Issue 15806014: Reduce usage of WebString::data (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp

diff --git a/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp b/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp

index 0815ad1f3dcf6276a56829efa4610e875a24cf02..cf579cabe0d829be642cb045af22bdc2b227ad59 100644

--- a/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp

+++ b/Tools/DumpRenderTree/chromium/TestRunner/src/EventSender.cpp

@@ -616,7 +616,7 @@ void EventSender::keyDown(const CppArgumentList& arguments, CppVariant* result)

if (!code) {

WebString webCodeStr = WebString::fromUTF8(codeStr.data(), codeStr.size());

WEBKIT_ASSERT(webCodeStr.length() == 1);

- text = code = webCodeStr.data()[0];

+ text = code = webCodeStr.at(0);

needsShiftKeyModifier = needsShiftModifier(code);

if ((code & 0xFF) >= 'a' && (code & 0xFF) <= 'z')

code -= 'a' - 'A';