Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1580543002: bluetooth: Chrome OS UI code fix. (Closed)

Created:
4 years, 11 months ago by scheib
Modified:
4 years, 11 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, Dan Beam, Kai Jiang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Chrome OS UI code fix. Previous patch https://codereview.chromium.org/1464443002 had a typo in new enum values. These values are not possible to generate on Chrome OS, and no test device generates them. BUG=531058 Committed: https://crrev.com/92d3e68a7e6dff9574c53fb8401aa941ef5df5a1 Cr-Commit-Position: refs/heads/master@{#368694}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/resources/options/chromeos/bluetooth_pair_device_overlay.js View 1 chunk +5 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
scheib
4 years, 11 months ago (2016-01-11 21:31:59 UTC) #3
stevenjb
lgtm
4 years, 11 months ago (2016-01-11 22:04:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580543002/1
4 years, 11 months ago (2016-01-11 22:05:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 22:36:31 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 22:37:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92d3e68a7e6dff9574c53fb8401aa941ef5df5a1
Cr-Commit-Position: refs/heads/master@{#368694}

Powered by Google App Engine
This is Rietveld 408576698