bluetooth: android: Code cleanup fixing comments, typos, simplified names.

bluetooth: android: Code cleanup fixing comments, typos, simplified names.

Fixed typo of Carachteristic.
Improved comments.
Fixed copied comments using 'Service' to 'Characteristic'.
Simplified and corrected names:
  ChromeBluetoothDevice -> ChromeDevice
  instanceID -> instance_id
Removed "cr." TAG prefix as per docs/android_logging.md

Committed: https://crrev.com/494b0b286b5a0d1dc3816aaa57ab8c77bead54f1
Cr-Commit-Position: refs/heads/master@{#368942}

[scheib, 2016-01-10 01:55:36]

Description was changed from

==========
bluetooth: android: Code cleanup fixing comments, typos, simplified names.

Fixed typo of Carachteristic.
Improved comments.
Fixed copied comments using 'Service' to 'Characteristic'.
Simplified and corrected names:
  ChromeBluetoothDevice -> ChromeDevice
  instanceID -> instance_id
==========

to

==========
bluetooth: android: Code cleanup fixing comments, typos, simplified names.

Fixed typo of Carachteristic.
Improved comments.
Fixed copied comments using 'Service' to 'Characteristic'.
Simplified and corrected names:
  ChromeBluetoothDevice -> ChromeDevice
  instanceID -> instance_id
Removed "cr." TAG prefix as per docs/android_logging.md
==========

[scheib, 2016-01-10 01:55:43]

Patchset #1 (id:1) has been deleted

[scheib, 2016-01-10 05:11:33]

scheib@chromium.org changed reviewers:
+ jyasskin@chromium.org

[Jeffrey Yasskin, 2016-01-12 17:00:30]

lgtm

https://codereview.chromium.org/1572873002/diff/40001/device/bluetooth/androi...
File
device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java
(right):

https://codereview.chromium.org/1572873002/diff/40001/device/bluetooth/androi...
device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java:23:
final Wrappers.BluetoothGattCharacteristicWrapper mCharacteristic;
I wonder if we should be calling this "mAndroidCharacteristic", to be explicit
on both sides rather than just the Chrome side. No need to change it unless you
think it's a good idea.

https://codereview.chromium.org/1572873002/diff/40001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_remote_gatt_service_android.h (right):

https://codereview.chromium.org/1572873002/diff/40001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_service_android.h:82: //
|characteristics_| DCHECKing that it has not already been created.
Add a comma before DCHECKing.

[scheib, 2016-01-12 17:54:36]

https://codereview.chromium.org/1572873002/diff/40001/device/bluetooth/androi...
File
device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java
(right):

https://codereview.chromium.org/1572873002/diff/40001/device/bluetooth/androi...
device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothRemoteGattCharacteristic.java:23:
final Wrappers.BluetoothGattCharacteristicWrapper mCharacteristic;
On 2016/01/12 17:00:30, Jeffrey Yasskin wrote:
> I wonder if we should be calling this "mAndroidCharacteristic", to be explicit
> on both sides rather than just the Chrome side. No need to change it unless
you
> think it's a good idea.

I've considered, but think I'll keep the shorter names:
Want clarity - but balanced with being succinct.
At this layer the mCharacteristic represents the most 'native' concept
of characteristic available to this code. Other objects that aren't as 'native'
but are peer or otherwise known high level objects are decorated with clarifying
names.

https://codereview.chromium.org/1572873002/diff/40001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_remote_gatt_service_android.h (right):

https://codereview.chromium.org/1572873002/diff/40001/device/bluetooth/blueto...
device/bluetooth/bluetooth_remote_gatt_service_android.h:82: //
|characteristics_| DCHECKing that it has not already been created.
On 2016/01/12 17:00:30, Jeffrey Yasskin wrote:
> Add a comma before DCHECKing.

Done.

[scheib, 2016-01-12 17:54:56]

The CQ bit was checked by scheib@chromium.org

[scheib, 2016-01-12 17:54:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
jyasskin@chromium.org
Link to the patchset: https://codereview.chromium.org/1572873002/#ps60001
(title: "comma")

[commit-bot: I haz the power, 2016-01-12 17:56:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1572873002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1572873002/60001

[commit-bot: I haz the power, 2016-01-12 19:20:59]

Description was changed from

==========
bluetooth: android: Code cleanup fixing comments, typos, simplified names.

Fixed typo of Carachteristic.
Improved comments.
Fixed copied comments using 'Service' to 'Characteristic'.
Simplified and corrected names:
  ChromeBluetoothDevice -> ChromeDevice
  instanceID -> instance_id
Removed "cr." TAG prefix as per docs/android_logging.md
==========

to

==========
bluetooth: android: Code cleanup fixing comments, typos, simplified names.

Fixed typo of Carachteristic.
Improved comments.
Fixed copied comments using 'Service' to 'Characteristic'.
Simplified and corrected names:
  ChromeBluetoothDevice -> ChromeDevice
  instanceID -> instance_id
Removed "cr." TAG prefix as per docs/android_logging.md
==========

[commit-bot: I haz the power, 2016-01-12 19:20:59]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-01-12 19:21:52]

Description was changed from

==========
bluetooth: android: Code cleanup fixing comments, typos, simplified names.

Fixed typo of Carachteristic.
Improved comments.
Fixed copied comments using 'Service' to 'Characteristic'.
Simplified and corrected names:
  ChromeBluetoothDevice -> ChromeDevice
  instanceID -> instance_id
Removed "cr." TAG prefix as per docs/android_logging.md
==========

to

==========
bluetooth: android: Code cleanup fixing comments, typos, simplified names.

Fixed typo of Carachteristic.
Improved comments.
Fixed copied comments using 'Service' to 'Characteristic'.
Simplified and corrected names:
  ChromeBluetoothDevice -> ChromeDevice
  instanceID -> instance_id
Removed "cr." TAG prefix as per docs/android_logging.md

Committed: https://crrev.com/494b0b286b5a0d1dc3816aaa57ab8c77bead54f1
Cr-Commit-Position: refs/heads/master@{#368942}
==========

[commit-bot: I haz the power, 2016-01-12 19:21:52]

Patchset 3 (id:??) landed as
https://crrev.com/494b0b286b5a0d1dc3816aaa57ab8c77bead54f1
Cr-Commit-Position: refs/heads/master@{#368942}