chrome/browser/ui/search_engines/keyword_editor_controller.cc - Issue 15805002: Modify extension omnibox keywords to be user-configurable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search_engines/keyword_editor_controller.cc

Issue 15805002: Modify extension omnibox keywords to be user-configurable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Peter's and Dan's requests Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/search_engine_manager.js ('K') | « chrome/browser/search_engines/template_url_service.cc ('k') | chrome/browser/ui/search_engines/template_url_table_model.h » ('j') | chrome/browser/ui/search_engines/template_url_table_model.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/search_engines/keyword_editor_controller.cc

diff --git a/chrome/browser/ui/search_engines/keyword_editor_controller.cc b/chrome/browser/ui/search_engines/keyword_editor_controller.cc

index 132ce860fd85be65088598cf392c6bb2e2fb762b..a44ab2dae36fc9ac5280a2fff157781c9cc732ec 100644

--- a/chrome/browser/ui/search_engines/keyword_editor_controller.cc

+++ b/chrome/browser/ui/search_engines/keyword_editor_controller.cc

@@ -39,12 +39,7 @@ int KeywordEditorController::AddTemplateURL(const string16& title,

content::RecordAction(UserMetricsAction("KeywordEditor_AddKeyword"));

- // There's a bug (1090726) in TableView with groups enabled such that newly

- // added items in groups ALWAYS appear at the end, regardless of the index

- // passed in. Worse yet, the selected rows get messed up when this happens

- // causing other problems. As a work around we always add the item to the end

- // of the list.

- const int new_index = table_model_->RowCount();

+ const int new_index = table_model_->last_other_engine_index();

Aaron Jacobs 2013/05/31 03:07:24 I'm not sure if the mentioned bug was officially c

Peter Kasting 2013/06/01 01:38:03 This was an old internal Google bug that was cover

table_model_->Add(new_index, title, keyword, url);

return new_index;