Modify extension omnibox keywords to be user-configurable

chrome/browser/ui/search_engines/keyword_editor_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/search_engines/keyword_editor_controller.h"
 
 #include "base/prefs/pref_registry_simple.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/search_engines/template_url.h"
@@ skipping 21 matching lines @@
   registry->RegisterDictionaryPref(prefs::kKeywordEditorWindowPlacement);
 }
 
 int KeywordEditorController::AddTemplateURL(const string16& title,
                                             const string16& keyword,
                                             const std::string& url) {
   DCHECK(!url.empty());
 
   content::RecordAction(UserMetricsAction("KeywordEditor_AddKeyword"));
 
-  // There's a bug (1090726) in TableView with groups enabled such that newly
-  // added items in groups ALWAYS appear at the end, regardless of the index
-  // passed in. Worse yet, the selected rows get messed up when this happens
-  // causing other problems. As a work around we always add the item to the end
-  // of the list.
-  const int new_index = table_model_->RowCount();
+  const int new_index = table_model_->last_other_engine_index();

[Aaron Jacobs, 2013/05/31 03:07:24]

I'm not sure if the mentioned bug was officially closed, as I can not find it
either on codereview.chromium.org or crbug.com, but I need to change the value,
and it seems to be working.

[Peter Kasting, 2013/06/01 01:38:03]

This was an old internal Google bug that was covered publicly on
http://crbug.com/95 .  I think it's safe to not worry about :)

   table_model_->Add(new_index, title, keyword, url);
 
   return new_index;
 }
 
 void KeywordEditorController::ModifyTemplateURL(TemplateURL* template_url,
                                                 const string16& title,
                                                 const string16& keyword,
                                                 const std::string& url) {
   DCHECK(!url.empty());
@@ skipping 40 matching lines @@
   return url_model()->loaded();
 }
 
 TemplateURL* KeywordEditorController::GetTemplateURL(int index) {
   return table_model_->GetTemplateURL(index);
 }
 
 TemplateURLService* KeywordEditorController::url_model() const {
   return table_model_->template_url_service();
 }