Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3600)

Unified Diff: chrome/browser/resources/options/search_engine_manager.js

Issue 15805002: Modify extension omnibox keywords to be user-configurable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Peter's and Dan's requests Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/search_engine_manager.js
diff --git a/chrome/browser/resources/options/search_engine_manager.js b/chrome/browser/resources/options/search_engine_manager.js
index dc5cf25179fc4c18c7f1b0eed2fc0c2dfc663a46..b0fd73229b4bc2e24d1e6e50dbdde7eb7cd91e65 100644
--- a/chrome/browser/resources/options/search_engine_manager.js
+++ b/chrome/browser/resources/options/search_engine_manager.js
@@ -37,7 +37,20 @@ cr.define('options', function() {
/**
* List for extension keywords.
* @private
- extensionList_ : null,
+ */
+ extensionList_: null,
+
+ get defaultsList() {
+ return this.defaultsList_;
+ },
+
+ get othersList() {
+ return this.othersList_;
+ },
+
+ get extensionList() {
+ return this.extensionList_;
+ },
/** inheritDoc */
initializePage: function() {
@@ -112,11 +125,12 @@ cr.define('options', function() {
};
SearchEngineManager.validityCheckCallback = function(validity, modelIndex) {
- // Forward to both lists; the one without a matching modelIndex will ignore
- // it.
- SearchEngineManager.getInstance().defaultsList_.validationComplete(
+ // Forward to all lists; those without a matching modelIndex will ignore it.
+ SearchEngineManager.getInstance().defaultsList.validationComplete(
+ validity, modelIndex);
+ SearchEngineManager.getInstance().othersList.validationComplete(
validity, modelIndex);
- SearchEngineManager.getInstance().othersList_.validationComplete(
+ SearchEngineManager.getInstance().extensionList.validationComplete(
validity, modelIndex);
};

Powered by Google App Engine
This is Rietveld 408576698