Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 1580463002: Cherry pick to M48: give up on quad root if infinite (Closed)

Created:
4 years, 11 months ago by hcm
Modified:
4 years, 11 months ago
Reviewers:
caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@m48
Target Ref:
refs/heads/chrome/m48
Project:
skia
Visibility:
Public.

Description

give up on quad root if infinite SkPath::contains() uses SkFindUnitQuadRoots to see which side of a curve a point is on. If the intermediate exceeds a float, return no found root. R=reed@google.com BUG=572406 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1556353002 Review URL: https://codereview.chromium.org/1556353002 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/261f0b48c062734a6f88ae6bde7f23aede550728

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/core/SkGeometry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathTest.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580463002/1
4 years, 11 months ago (2016-01-11 18:25:19 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 11 months ago (2016-01-11 18:25:20 UTC) #6
caryclark
lgtm
4 years, 11 months ago (2016-01-11 19:03:21 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 19:04:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/261f0b48c062734a6f88ae6bde7f23aede550728

Powered by Google App Engine
This is Rietveld 408576698