give up on quad root if infinite

give up on quad root if infinite

SkPath::contains() uses SkFindUnitQuadRoots to see
which side of a curve a point is on. If the
intermediate exceeds a float, return no found root.

R=reed@google.com
BUG=572406
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1556353002

Committed: https://skia.googlesource.com/skia/+/dbaec7323f20c3a7e8a234dac9dfb8a9446a2717

[caryclark, 2016-01-05 14:01:21]

Description was changed from

==========
give up on quad root if infinite

SkPath::contains() uses SkFindUnitQuadRoots to see
which side of a curve a point is on. If the
intermediate exceeds a float, return no found root.

R=reed@google.com
BUG=572406
==========

to

==========
give up on quad root if infinite

SkPath::contains() uses SkFindUnitQuadRoots to see
which side of a curve a point is on. If the
intermediate exceeds a float, return no found root.

R=reed@google.com
BUG=572406
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[caryclark, 2016-01-05 14:02:47]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2016-01-05 14:02:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1556353002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1556353002/1

[commit-bot: I haz the power, 2016-01-05 14:02:59]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-01-05 20:02 UTC

[reed1, 2016-01-05 14:19:36]

// TODO: consider recomputing the sqrt via doubles if we're not finite

lgtm

[commit-bot: I haz the power, 2016-01-05 14:20:12]

Description was changed from

==========
give up on quad root if infinite

SkPath::contains() uses SkFindUnitQuadRoots to see
which side of a curve a point is on. If the
intermediate exceeds a float, return no found root.

R=reed@google.com
BUG=572406
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
give up on quad root if infinite

SkPath::contains() uses SkFindUnitQuadRoots to see
which side of a curve a point is on. If the
intermediate exceeds a float, return no found root.

R=reed@google.com
BUG=572406
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/dbaec7323f20c3a7e8a234dac9dfb8a9446a2717
==========

[commit-bot: I haz the power, 2016-01-05 14:20:12]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dbaec7323f20c3a7e8a234dac9dfb8a9446a2717

[dogben, 2016-01-06 15:20:58]

On 2016/01/05 at 14:20:12, commit-bot wrote:
> Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dbaec7323f20c3a7e8a234dac9dfb8a9446a2717

This CL seems to have caused Google3 MSAN to fail due to
use-of-uninitialized-value. Stack trace is:

    #0 0x7f91bc7977c0 in winding_mono_conic(SkConic const&, float, float, int*)
src/core/SkPath.cpp:2709:9
    #1 0x7f91bc794bc3 in winding_conic(SkPoint const*, float, float, float,
int*) src/core/SkPath.cpp:2775:13
    #2 0x7f91bc793b84 in SkPath::contains(float, float) const
src/core/SkPath.cpp:3022:22
    #3 0x7f91bdc51142 in test_contains(skiatest::Reporter*)
tests/PathTest.cpp:3518:12
    #4 0x7f91bd55e171 in run_test(skiatest::Test*) dm/DM.cpp:1020:9
    #5 0x7f91bc8e9161 in (anonymous namespace)::ThreadPool::Loop(void*)
src/core/SkTaskGroup.cpp:176:13
    #6 0x7f91bcf3bddb in thread_start(void*)
src/utils/SkThreadUtils_pthread.cpp:66:9
    #7 0x7f91b880883f in start_thread (libpthread.so.0+0x683f)
    #8 0x7f91b82632ec in __clone (libc.so.6+0x372ec)

SUMMARY: MemorySanitizer: use-of-uninitialized-value src/core/SkPath.cpp:2709:9
in winding_mono_conic(SkConic const&, float, float, int*)

[dogben, 2016-01-06 15:21:21]

benjaminwagner@google.com changed reviewers:
+ benjaminwagner@google.com

[dogben, 2016-01-06 15:21:31]

benjaminwagner@google.com changed reviewers:
- benjaminwagner@google.com

[mtklein, 2016-01-06 15:47:15]

On 2016/01/06 15:21:31, Ben Wagner wrote:

(https://bugs.chromium.org/p/skia/issues/detail?id=4757)