Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1580443002: Gold: Patch linker to implement --long-plt flag. (Closed)

Created:
4 years, 11 months ago by pcc1
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gold: Patch linker to implement --long-plt flag. Also modify script to extract binutils sources from tarball and apply patches unconditionally to avoid problems with later runs if a patch fails to apply. Re-land of https://codereview.chromium.org/1537083003/ now that the binutils binaries are uploaded to goma. BUG=554017 R=thestig@chromium.org Committed: https://crrev.com/37afebf7351a4918410829eac48f7125ed6fe3e3 Cr-Commit-Position: refs/heads/master@{#368648}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -21 lines) Patch
M third_party/binutils/Linux_ia32/binutils.tar.bz2.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/binutils/Linux_x64/binutils.tar.bz2.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/binutils/README.chromium View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/binutils/build-all.sh View 1 chunk +23 lines, -19 lines 0 comments Download
A third_party/binutils/long-plt.patch View 1 chunk +232 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pcc1
4 years, 11 months ago (2016-01-11 17:30:02 UTC) #1
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-11 19:20:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580443002/1
4 years, 11 months ago (2016-01-11 19:22:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 20:10:53 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 20:12:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37afebf7351a4918410829eac48f7125ed6fe3e3
Cr-Commit-Position: refs/heads/master@{#368648}

Powered by Google App Engine
This is Rietveld 408576698