Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1537083003: Gold: Patch linker to implement --long-plt flag. (Closed)

Created:
5 years ago by pcc1
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gold: Patch linker to implement --long-plt flag. Also modify script to extract binutils sources from tarball and apply patches unconditionally to avoid problems with later runs if a patch fails to apply. BUG=554017 R=thestig@chromium.org Committed: https://crrev.com/b7b010e70c37389b4e0ee022e5fd09a7d6bb394d Cr-Commit-Position: refs/heads/master@{#366267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -21 lines) Patch
M third_party/binutils/Linux_ia32/binutils.tar.bz2.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/binutils/Linux_x64/binutils.tar.bz2.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/binutils/README.chromium View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/binutils/build-all.sh View 1 chunk +23 lines, -19 lines 0 comments Download
A third_party/binutils/long-plt.patch View 1 chunk +232 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pcc1
5 years ago (2015-12-19 01:18:17 UTC) #1
Lei Zhang
lgtm
5 years ago (2015-12-19 05:16:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537083003/1
5 years ago (2015-12-19 05:17:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-19 05:44:44 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b7b010e70c37389b4e0ee022e5fd09a7d6bb394d Cr-Commit-Position: refs/heads/master@{#366267}
5 years ago (2015-12-19 05:45:36 UTC) #7
Nico
5 years ago (2015-12-23 20:54:21 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1550453002/ by thakis@chromium.org.

The reason for reverting is: Looks like this blocks pushing new clangs to goma
(maybe the new binutils weren't uploaded there?), and also didn't help with the
bug it was supposed to help with. Reverting in the hope that it'll unblock clang
rolls..

Powered by Google App Engine
This is Rietveld 408576698