Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp

Issue 1580293008: Fix incorrect handling of small non-percentage value for 'startOffset' on <textPath> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp
index 617f3b6a6a78fd72a804d7f5c48bde202b4ea30a..1159c84e1b012764d74b5277d8d6c1b2add504d7 100644
--- a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp
@@ -172,14 +172,14 @@ void SVGTextLayoutEngine::beginTextPathLayout(SVGInlineFlowBox* flowBox)
m_inPathLayout = true;
LayoutSVGTextPath* textPath = &toLayoutSVGTextPath(flowBox->layoutObject());
-
Path path = textPath->layoutPath();
if (path.isEmpty())
return;
m_textPathCalculator = new Path::PositionCalculator(path);
m_textPathStartOffset = textPath->startOffset();
m_textPathLength = path.length();
- if (m_textPathStartOffset > 0 && m_textPathStartOffset <= 1)
+ if (textPath->isPercentageForStartOffset()
fs 2016/01/18 12:57:49 I'd suggest that you instead pass m_textPathLength
+ && m_textPathStartOffset > 0 && m_textPathStartOffset <= 1)
m_textPathStartOffset *= m_textPathLength;
SVGTextPathChunkBuilder textPathChunkLayoutBuilder;

Powered by Google App Engine
This is Rietveld 408576698