third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp - Issue 1580293008: Fix incorrect handling of small non-percentage value for 'startOffset' on <textPath>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp

Issue 1580293008: Fix incorrect handling of small non-percentage value for 'startOffset' on <textPath> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/svg/text/textpath-startoffset.html ('K') | « third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.h ('k') | third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp » ('j') | third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp

index 17ac253b8a6726f02687e2761ed833200ed49aaa..562c113ff1fa4cef35b07d471a6a00be7b05c821 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp

@@ -62,4 +62,9 @@ float LayoutSVGTextPath::startOffset() const

return toSVGTextPathElement(node())->startOffset()->currentValue()->valueAsPercentage();

}

+bool LayoutSVGTextPath::isPercentageForStartOffset() const

+ return toSVGTextPathElement(node())->startOffset()->currentValue()->isPercentage();

}