Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.h

Issue 1580293008: Fix incorrect handling of small non-percentage value for 'startOffset' on <textPath> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/text/textpath-startoffset-expected.html ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp » ('j') | third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.h
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.h
index 79b5f18bff88aa8cd62473719d0a762469b7f44b..66830fb8a0950e94869f5acc5d0eb5442e31c723 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.h
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.h
@@ -30,7 +30,7 @@ public:
explicit LayoutSVGTextPath(Element*);
Path layoutPath() const;
- float startOffset() const;
+ float calculateStartOffset(float length) const;
fs 2016/01/28 15:20:34 Nit: s/length/pathLength/
bool isChildAllowed(LayoutObject*, const ComputedStyle&) const override;
« no previous file with comments | « third_party/WebKit/LayoutTests/svg/text/textpath-startoffset-expected.html ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp » ('j') | third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698