Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1580283004: Notification custom layouts: keep settings icon and label together in rtl layout. (Closed)

Created:
4 years, 11 months ago by Michael van Ouwerkerk
Modified:
4 years, 11 months ago
Reviewers:
johnme, newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notification custom layouts: keep settings icon and label together in rtl layout. * This shrinks the settings button to its contents so there is also no blank space to tap that button * Screenshots: http://imgur.com/a/zrPta BUG=577161 Committed: https://crrev.com/eaefb53a84fb244749ab6b705b3a99b7319ec085 Cr-Commit-Position: refs/heads/master@{#369390}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Suppress RelativeOverlap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/android/java/res/layout/web_notification_big.xml View 1 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/android/java/res/values-v17/styles.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Michael van Ouwerkerk
Newton, could you take a look please? John, please take a look as you're really ...
4 years, 11 months ago (2016-01-13 14:16:10 UTC) #3
johnme
lgtm, thanks :)
4 years, 11 months ago (2016-01-13 14:18:34 UTC) #4
newt (away)
https://codereview.chromium.org/1580283004/diff/1/chrome/android/java/res/layout/web_notification_big.xml File chrome/android/java/res/layout/web_notification_big.xml (right): https://codereview.chromium.org/1580283004/diff/1/chrome/android/java/res/layout/web_notification_big.xml#newcode143 chrome/android/java/res/layout/web_notification_big.xml:143: <Button alternatively, you could simply set android:textAlignment="viewStart" on the ...
4 years, 11 months ago (2016-01-13 18:52:16 UTC) #5
newt (away)
current code lgtm too :)
4 years, 11 months ago (2016-01-13 19:01:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1580283004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1580283004/20001
4 years, 11 months ago (2016-01-14 10:20:14 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-14 10:59:53 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 11:01:15 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eaefb53a84fb244749ab6b705b3a99b7319ec085
Cr-Commit-Position: refs/heads/master@{#369390}

Powered by Google App Engine
This is Rietveld 408576698