Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: chrome/android/java/res/values-v17/styles.xml

Issue 1580283004: Notification custom layouts: keep settings icon and label together in rtl layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Suppress RelativeOverlap Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/java/res/layout/web_notification_big.xml ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <resources xmlns:tools="http://schemas.android.com/tools"> 6 <resources xmlns:tools="http://schemas.android.com/tools">
7 <!-- Q: Why put style resources under values-v17/ ? 7 <!-- Q: Why put style resources under values-v17/ ?
8 A: Problem: 8 A: Problem:
9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339. 9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339.
10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert 10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 </style> 317 </style>
318 <style name="WebNotificationButton" 318 <style name="WebNotificationButton"
319 parent="@android:style/Widget.DeviceDefault.Button.Borderless.Small"> 319 parent="@android:style/Widget.DeviceDefault.Button.Borderless.Small">
320 <!-- textColor from the 4.4.4 notification_action.xml - no public aliase s. --> 320 <!-- textColor from the 4.4.4 notification_action.xml - no public aliase s. -->
321 <item name="android:textColor">#ccc</item> 321 <item name="android:textColor">#ccc</item>
322 </style> 322 </style>
323 <style name="WebNotificationSettingsButton" 323 <style name="WebNotificationSettingsButton"
324 parent="@style/WebNotificationButton"> 324 parent="@style/WebNotificationButton">
325 <item name="android:textAppearance">@style/TextAppearance.StatusBar.Even tContent.Line2</item> 325 <item name="android:textAppearance">@style/TextAppearance.StatusBar.Even tContent.Line2</item>
326 <item name="android:paddingStart">40dp</item> 326 <item name="android:paddingStart">40dp</item>
327 <!-- Margin at the end to avoid overlap with the small icon. -->
328 <item name="android:layout_marginEnd">24dp</item>
327 </style> 329 </style>
328 <style name="WebNotificationSettingsIcon"> 330 <style name="WebNotificationSettingsIcon">
329 <item name="android:layout_marginStart">8dp</item> 331 <item name="android:layout_marginStart">8dp</item>
330 </style> 332 </style>
331 <style name="WebNotificationLargeIcon"> 333 <style name="WebNotificationLargeIcon">
332 <item name="android:background">@drawable/notification_template_icon_bg< /item> 334 <item name="android:background">@drawable/notification_template_icon_bg< /item>
333 </style> 335 </style>
334 <style name="WebNotificationSmallIcon"> 336 <style name="WebNotificationSmallIcon">
335 <item name="android:alpha">0.6</item> 337 <item name="android:alpha">0.6</item>
336 </style> 338 </style>
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
487 <style name="UpdateMenuBadge"> 489 <style name="UpdateMenuBadge">
488 <item name="android:layout_height">@dimen/menu_badge_size</item> 490 <item name="android:layout_height">@dimen/menu_badge_size</item>
489 <item name="android:layout_width">@dimen/menu_badge_size</item> 491 <item name="android:layout_width">@dimen/menu_badge_size</item>
490 <item name="android:layout_gravity">end|bottom</item> 492 <item name="android:layout_gravity">end|bottom</item>
491 <item name="android:layout_marginBottom">14dp</item> 493 <item name="android:layout_marginBottom">14dp</item>
492 <item name="android:focusable">false</item> 494 <item name="android:focusable">false</item>
493 <item name="android:importantForAccessibility">no</item> 495 <item name="android:importantForAccessibility">no</item>
494 <item name="android:visibility">invisible</item> 496 <item name="android:visibility">invisible</item>
495 </style> 497 </style>
496 </resources> 498 </resources>
OLDNEW
« no previous file with comments | « chrome/android/java/res/layout/web_notification_big.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698