src/crankshaft/x64/lithium-gap-resolver-x64.cc - Issue 1580233003: [turbofan] avoid xchg instruction on Intel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/x64/lithium-gap-resolver-x64.cc

Issue 1580233003: [turbofan] avoid xchg instruction on Intel (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/x64/lithium-gap-resolver-x64.cc

diff --git a/src/crankshaft/x64/lithium-gap-resolver-x64.cc b/src/crankshaft/x64/lithium-gap-resolver-x64.cc

index cc65f188cebad2d047b2f24eeb4558fb5ba2f052..3808c377dc1f17b172549817d5240f1a14679216 100644

--- a/src/crankshaft/x64/lithium-gap-resolver-x64.cc

+++ b/src/crankshaft/x64/lithium-gap-resolver-x64.cc

@@ -244,7 +244,9 @@ void LGapResolver::EmitSwap(int index) {

// Swap two general-purpose registers.

- __ xchgq(dst, src);

+ __ movp(kScratchRegister, src);

+ __ movp(src, dst);

+ __ movp(dst, kScratchRegister);

} else if ((source->IsRegister() && destination->IsStackSlot()) ||

(source->IsStackSlot() && destination->IsRegister())) {