src/crankshaft/ia32/lithium-gap-resolver-ia32.cc - Issue 1580233003: [turbofan] avoid xchg instruction on Intel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/ia32/lithium-gap-resolver-ia32.cc

Issue 1580233003: [turbofan] avoid xchg instruction on Intel (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/ia32/lithium-gap-resolver-ia32.cc

diff --git a/src/crankshaft/ia32/lithium-gap-resolver-ia32.cc b/src/crankshaft/ia32/lithium-gap-resolver-ia32.cc

index b90f6bb21e05e2a6b8b1e15c7d73739d4055c84c..c3284df882790f92417c23419b6e801d92873d4e 100644

--- a/src/crankshaft/ia32/lithium-gap-resolver-ia32.cc

+++ b/src/crankshaft/ia32/lithium-gap-resolver-ia32.cc

@@ -369,7 +369,9 @@ void LGapResolver::EmitSwap(int index) {

// Register-register.

- __ xchg(dst, src);

+ __ push(src);

+ __ mov(src, dst);

+ __ pop(dst);

} else if ((source->IsRegister() && destination->IsStackSlot()) ||

(source->IsStackSlot() && destination->IsRegister())) {