Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1580153002: [Sync] Make InvalidationPreferences.commit() thread-safe. (Closed)

Created:
4 years, 11 months ago by maxbogue
Modified:
4 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

[Sync] Make InvalidationPreferences.commit() thread-safe. The lock is static because we make many instances of InvalidationPreferences but only one can be committing at a time. BUG=568369 Review URL: https://codereview.chromium.org/1512183002 Cr-Commit-Position: refs/heads/master@{#364410} (cherry picked from commit dea09d3b7ac5fd50ca7ba3baa70fb37920895487) Committed: https://chromium.googlesource.com/chromium/src/+/c0118aff422c78dd244e7ef6d877ce5ef7874441

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M sync/android/java/src/org/chromium/sync/notifier/InvalidationPreferences.java View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
maxbogue
4 years, 11 months ago (2016-01-12 20:24:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c0118aff422c78dd244e7ef6d877ce5ef7874441.

Powered by Google App Engine
This is Rietveld 408576698