Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1512183002: [Sync] Make InvalidationPreferences.commit() thread-safe. (Closed)

Created:
5 years ago by maxbogue
Modified:
5 years ago
Reviewers:
nyquist
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Make InvalidationPreferences.commit() thread-safe. The lock is static because we make many instances of InvalidationPreferences but only one can be committing at a time. BUG=568369 Committed: https://crrev.com/dea09d3b7ac5fd50ca7ba3baa70fb37920895487 Cr-Commit-Position: refs/heads/master@{#364410}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M sync/android/java/src/org/chromium/sync/notifier/InvalidationPreferences.java View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
maxbogue
Tommy, PTAL.
5 years ago (2015-12-10 02:12:10 UTC) #2
nyquist
lgtm
5 years ago (2015-12-10 18:27:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512183002/1
5 years ago (2015-12-10 18:35:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 18:43:06 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-10 18:43:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dea09d3b7ac5fd50ca7ba3baa70fb37920895487
Cr-Commit-Position: refs/heads/master@{#364410}

Powered by Google App Engine
This is Rietveld 408576698