Issue 15799007: Revert 203027 "Revert 203025 "Make the copy of GURL in src/url b..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15799007: Revert 203027 "Revert 203025 "Make the copy of GURL in src/url b..." (Closed)

Created:
7 years, 6 months ago by Lei Zhang

Modified:
7 years, 6 months ago

Reviewers:
Lei Zhang, tfarina

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 203027 "Revert 203025 "Make the copy of GURL in src/url b..." > Revert 203025 "Make the copy of GURL in src/url buildable as a c..." > > > Make the copy of GURL in src/url buildable as a component build. (try 2) > > > > BUG=229660 > > TBR=brettw > > > > Review URL: https://chromiumcodereview.appspot.com/15805003 > > TBR=thestig@chromium.org > > Review URL: https://codereview.chromium.org/15848009 TBR=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203324

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+406 lines, -390 lines)			Patch
M	trunk/src/url/gurl.h	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	trunk/src/url/url.gyp	View	4 chunks	+7 lines, -7 lines	0 comments	Download
M	trunk/src/url/url_canon.h	View	16 chunks	+246 lines, -241 lines	0 comments	Download
M	trunk/src/url/url_canon_icu.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	trunk/src/url/url_canon_internal.h	View	5 chunks	+13 lines, -12 lines	0 comments	Download
M	trunk/src/url/url_canon_ip.h	View	4 chunks	+19 lines, -18 lines	0 comments	Download
A +	trunk/src/url/url_export.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/url/url_parse.h	View	8 chunks	+56 lines, -48 lines	0 comments	Download
M	trunk/src/url/url_util.h	View	10 chunks	+59 lines, -58 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tfarina

lgtm, trunk/src/? :) This might be because of your Base URL: svn://svn.chromium.org/chrome/ Thanks for bringing ...

7 years, 6 months ago (2013-05-31 03:43:14 UTC) #3

Lei Zhang

7 years, 6 months ago (2013-05-31 03:56:30 UTC) #4

Message was sent while issue was closed.

On 2013/05/31 03:43:14, tfarina wrote:
> lgtm,
> 
> trunk/src/? :) This might be because of your Base URL:
> svn://svn.chromium.org/chrome/
> 
> Thanks for bringing it back!

It's what drover likes to do. Hope it sticks this time.

Expand Messages | Collapse Messages