Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1579793002: Precompilation: Use smaller values for inlining_constant_arguments_max/min_size_threshold. (Closed)

Created:
4 years, 11 months ago by rmacnak
Modified:
4 years, 11 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Precompilation: Use smaller values for inlining_constant_arguments_max/min_size_threshold. dart2js ARM precompiled snapshot: 25087606 => 24608537 (-1.91%) --noopt benchmarks: geom mean -0.11% (ARM Cortex A53) R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/2cec39657af311c343b8d2d61945c263289e4d77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M runtime/vm/flow_graph_compiler.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
VMIsolate(CodeSize): 2108095 Isolate(CodeSize): 9509447 Instructions(CodeSize): 13470064 Total(CodeSize): 25087606 DeltaBlue(RunTime): 90579.12265217392 us. DeltaBlueClosures(RunTime): 82638.90544 us. Richards(RunTime): ...
4 years, 11 months ago (2016-01-11 23:13:42 UTC) #2
Florian Schneider
lgtm
4 years, 11 months ago (2016-01-12 10:39:43 UTC) #3
rmacnak
4 years, 11 months ago (2016-01-12 20:50:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2cec39657af311c343b8d2d61945c263289e4d77 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698