Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: runtime/vm/flow_graph_compiler.cc

Issue 1579793002: Precompilation: Use smaller values for inlining_constant_arguments_max/min_size_threshold. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_XXX.
6 6
7 #include "vm/flow_graph_compiler.h" 7 #include "vm/flow_graph_compiler.h"
8 8
9 #include "vm/bit_vector.h" 9 #include "vm/bit_vector.h"
10 #include "vm/cha.h" 10 #include "vm/cha.h"
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 DECLARE_FLAG(bool, interpret_irregexp); 77 DECLARE_FLAG(bool, interpret_irregexp);
78 DECLARE_FLAG(bool, enable_mirrors); 78 DECLARE_FLAG(bool, enable_mirrors);
79 DECLARE_FLAG(bool, link_natives_lazily); 79 DECLARE_FLAG(bool, link_natives_lazily);
80 DECLARE_FLAG(bool, trace_compiler); 80 DECLARE_FLAG(bool, trace_compiler);
81 DECLARE_FLAG(int, inlining_hotness); 81 DECLARE_FLAG(int, inlining_hotness);
82 DECLARE_FLAG(int, inlining_size_threshold); 82 DECLARE_FLAG(int, inlining_size_threshold);
83 DECLARE_FLAG(int, inlining_callee_size_threshold); 83 DECLARE_FLAG(int, inlining_callee_size_threshold);
84 DECLARE_FLAG(int, inline_getters_setters_smaller_than); 84 DECLARE_FLAG(int, inline_getters_setters_smaller_than);
85 DECLARE_FLAG(int, inlining_depth_threshold); 85 DECLARE_FLAG(int, inlining_depth_threshold);
86 DECLARE_FLAG(int, inlining_caller_size_threshold); 86 DECLARE_FLAG(int, inlining_caller_size_threshold);
87 DECLARE_FLAG(int, inlining_constant_arguments_max_size_threshold);
88 DECLARE_FLAG(int, inlining_constant_arguments_min_size_threshold);
87 89
88 bool FLAG_precompilation = false; 90 bool FLAG_precompilation = false;
89 static void PrecompilationModeHandler(bool value) { 91 static void PrecompilationModeHandler(bool value) {
90 if (value) { 92 if (value) {
91 #if defined(TARGET_ARCH_IA32) 93 #if defined(TARGET_ARCH_IA32)
92 FATAL("Precompilation not supported on IA32"); 94 FATAL("Precompilation not supported on IA32");
93 #endif 95 #endif
94 FLAG_precompilation = true; 96 FLAG_precompilation = true;
95 97
96 FLAG_always_megamorphic_calls = true; 98 FLAG_always_megamorphic_calls = true;
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 // when making inlining decisions. 130 // when making inlining decisions.
129 FLAG_inlining_hotness = 0; 131 FLAG_inlining_hotness = 0;
130 // Use smaller thresholds in precompilation as we are compiling everything 132 // Use smaller thresholds in precompilation as we are compiling everything
131 // with the optimizing compiler instead of only hot functions. 133 // with the optimizing compiler instead of only hot functions.
132 FLAG_inlining_size_threshold = 5; 134 FLAG_inlining_size_threshold = 5;
133 FLAG_inline_getters_setters_smaller_than = 5; 135 FLAG_inline_getters_setters_smaller_than = 5;
134 FLAG_inlining_callee_size_threshold = 20; 136 FLAG_inlining_callee_size_threshold = 20;
135 FLAG_inlining_depth_threshold = 2; 137 FLAG_inlining_depth_threshold = 2;
136 FLAG_inlining_caller_size_threshold = 1000; 138 FLAG_inlining_caller_size_threshold = 1000;
137 139
140 FLAG_inlining_constant_arguments_max_size_threshold = 100;
141 FLAG_inlining_constant_arguments_min_size_threshold = 30;
142
138 // Background compilation relies on two-stage compilation pipeline, 143 // Background compilation relies on two-stage compilation pipeline,
139 // while precompilation has only one. 144 // while precompilation has only one.
140 FLAG_background_compilation = false; 145 FLAG_background_compilation = false;
141 FLAG_collect_dynamic_function_names = true; 146 FLAG_collect_dynamic_function_names = true;
142 } 147 }
143 } 148 }
144 149
145 150
146 DEFINE_FLAG_HANDLER(PrecompilationModeHandler, 151 DEFINE_FLAG_HANDLER(PrecompilationModeHandler,
147 precompilation, 152 precompilation,
(...skipping 1729 matching lines...) Expand 10 before | Expand all | Expand 10 after
1877 1882
1878 1883
1879 void FlowGraphCompiler::FrameStateClear() { 1884 void FlowGraphCompiler::FrameStateClear() {
1880 ASSERT(!is_optimizing()); 1885 ASSERT(!is_optimizing());
1881 frame_state_.TruncateTo(0); 1886 frame_state_.TruncateTo(0);
1882 } 1887 }
1883 #endif 1888 #endif
1884 1889
1885 1890
1886 } // namespace dart 1891 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698