[Telemetry] Update telemetry_unittests to use tools/perf/run_telemetry_tests

[Telemetry] Update telemetry_unittests to use tools/perf/run_telemetry_tests

BUG=575711
,

Committed: https://crrev.com/a9191918994fcda4c8128cde6c1925066df2f08b
Cr-Commit-Position: refs/heads/master@{#369220}

[nednguyen, 2016-01-11 21:52:53]

Patchset #1 (id:1) has been deleted

[nednguyen, 2016-01-11 21:52:59]

Description was changed from

==========
[Telemetry] Update telemetry_unittests to use tools/perf/run_telemetry_tests

BUG=
==========

to

==========
[Telemetry] Update telemetry_unittests to use tools/perf/run_telemetry_tests

BUG=575711
==========

[nednguyen, 2016-01-11 21:53:32]

nednguyen@google.com changed reviewers:
+ aiolos@chromium.org, eakuefner@chromium.org, maruel@chromium.org,
phajdan.jr@chromium.org

[aiolos (Not reviewing), 2016-01-11 21:58:45]

https://codereview.chromium.org/1579743002/diff/20001/tools/perf/run_telemetr...
File tools/perf/run_telemetry_tests (right):

https://codereview.chromium.org/1579743002/diff/20001/tools/perf/run_telemetr...
tools/perf/run_telemetry_tests:17: _TELEMETRY_DIR =
os.path.join(os.path.dirname(__file__), '..', 'telemetry')
Why aren't you using the path_util.GetTelemetryDir here? This adds one more
location to update when we move telemetry.

https://codereview.chromium.org/1579743002/diff/20001/tools/perf/run_telemetr...
tools/perf/run_telemetry_tests:24: _TELEMETRY_DIR)
should this be top_level_dir=_TELEMETRY_DIR instead?

[nednguyen, 2016-01-11 22:20:31]

Description was changed from

==========
[Telemetry] Update telemetry_unittests to use tools/perf/run_telemetry_tests

BUG=575711
==========

to

==========
[Telemetry] Update telemetry_unittests to use tools/perf/run_telemetry_tests

BUG=575711,
==========

[nednguyen, 2016-01-11 22:25:21]

https://codereview.chromium.org/1579743002/diff/20001/tools/perf/run_telemetr...
File tools/perf/run_telemetry_tests (right):

https://codereview.chromium.org/1579743002/diff/20001/tools/perf/run_telemetr...
tools/perf/run_telemetry_tests:17: _TELEMETRY_DIR =
os.path.join(os.path.dirname(__file__), '..', 'telemetry')
On 2016/01/11 21:58:45, aiolos wrote:
> Why aren't you using the path_util.GetTelemetryDir here? This adds one more
> location to update when we move telemetry.

Done. Also filed crbug.com/576414

https://codereview.chromium.org/1579743002/diff/20001/tools/perf/run_telemetr...
tools/perf/run_telemetry_tests:24: _TELEMETRY_DIR)
On 2016/01/11 21:58:45, aiolos wrote:
> should this be top_level_dir=_TELEMETRY_DIR instead?

Done.

[nednguyen(REVIEW IN OTHER ACC), 2016-01-13 01:20:44]

On 2016/01/11 22:25:21, nednguyen wrote:
>
https://codereview.chromium.org/1579743002/diff/20001/tools/perf/run_telemetr...
> File tools/perf/run_telemetry_tests (right):
> 
>
https://codereview.chromium.org/1579743002/diff/20001/tools/perf/run_telemetr...
> tools/perf/run_telemetry_tests:17: _TELEMETRY_DIR =
> os.path.join(os.path.dirname(__file__), '..', 'telemetry')
> On 2016/01/11 21:58:45, aiolos wrote:
> > Why aren't you using the path_util.GetTelemetryDir here? This adds one more
> > location to update when we move telemetry.
> 
> Done. Also filed crbug.com/576414
> 
>
https://codereview.chromium.org/1579743002/diff/20001/tools/perf/run_telemetr...
> tools/perf/run_telemetry_tests:24: _TELEMETRY_DIR)
> On 2016/01/11 21:58:45, aiolos wrote:
> > should this be top_level_dir=_TELEMETRY_DIR instead?
> 
> Done.

PTAL

[aiolos (Not reviewing), 2016-01-13 02:04:28]

lgtm

[eakuefner, 2016-01-13 02:19:37]

lgtm % nits

https://codereview.chromium.org/1579743002/diff/60001/tools/perf/run_telemetr...
File tools/perf/run_telemetry_tests (right):

https://codereview.chromium.org/1579743002/diff/60001/tools/perf/run_telemetr...
tools/perf/run_telemetry_tests:2: # Copyright 2015 The Chromium Authors. All
rights reserved.
2016

https://codereview.chromium.org/1579743002/diff/60001/tools/perf/run_telemetr...
tools/perf/run_telemetry_tests:17: _TELEMETRY_DIR =
os.path.join(os.path.dirname(__file__), '..', 'telemetry')
You don't need this, right?

[nednguyen, 2016-01-13 03:03:14]

https://codereview.chromium.org/1579743002/diff/60001/tools/perf/run_telemetr...
File tools/perf/run_telemetry_tests (right):

https://codereview.chromium.org/1579743002/diff/60001/tools/perf/run_telemetr...
tools/perf/run_telemetry_tests:2: # Copyright 2015 The Chromium Authors. All
rights reserved.
On 2016/01/13 02:19:37, eakuefner wrote:
> 2016

Done.

https://codereview.chromium.org/1579743002/diff/60001/tools/perf/run_telemetr...
tools/perf/run_telemetry_tests:17: _TELEMETRY_DIR =
os.path.join(os.path.dirname(__file__), '..', 'telemetry')
On 2016/01/13 02:19:36, eakuefner wrote:
> You don't need this, right?

Done.

[nednguyen, 2016-01-13 04:40:38]

On 2016/01/13 03:03:14, nednguyen wrote:
>
https://codereview.chromium.org/1579743002/diff/60001/tools/perf/run_telemetr...
> File tools/perf/run_telemetry_tests (right):
> 
>
https://codereview.chromium.org/1579743002/diff/60001/tools/perf/run_telemetr...
> tools/perf/run_telemetry_tests:2: # Copyright 2015 The Chromium Authors. All
> rights reserved.
> On 2016/01/13 02:19:37, eakuefner wrote:
> > 2016
> 
> Done.
> 
>
https://codereview.chromium.org/1579743002/diff/60001/tools/perf/run_telemetr...
> tools/perf/run_telemetry_tests:17: _TELEMETRY_DIR =
> os.path.join(os.path.dirname(__file__), '..', 'telemetry')
> On 2016/01/13 02:19:36, eakuefner wrote:
> > You don't need this, right?
> 
> Done.

Pawel, can I have your owner review to chrome/test/BUILD.gn	,
testing/buildbot/gn_isolate_map.pyl?
Marc, can I have you owner review to chrome/telemetry_unittests.isolate?

Thanks

[Paweł Hajdan Jr., 2016-01-13 08:51:11]

LGTM

[M-A Ruel, 2016-01-13 12:34:37]

lgtm

https://codereview.chromium.org/1579743002/diff/80001/tools/perf/chrome_telem...
File tools/perf/chrome_telemetry_build/chromium_config.py (right):

https://codereview.chromium.org/1579743002/diff/80001/tools/perf/chrome_telem...
tools/perf/chrome_telemetry_build/chromium_config.py:12:
os.path.join(os.path.dirname(__file__), '..', '..', '..'))
always use .os.path.abspath(__file__) instead of __file__, otherwise it is not
OS.chdir() safe which defeats the point.

https://codereview.chromium.org/1579743002/diff/80001/tools/perf/core/path_ut...
File tools/perf/core/path_util.py (right):

https://codereview.chromium.org/1579743002/diff/80001/tools/perf/core/path_ut...
tools/perf/core/path_util.py:8: sys.path.insert(1,
os.path.join(os.path.dirname(__file__), '..'))
same

[nednguyen, 2016-01-13 17:18:20]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2016-01-13 17:18:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org, aiolos@chromium.org, maruel@chromium.org,
phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/1579743002/#ps100001
(title: "Address Marc's comments")

[commit-bot: I haz the power, 2016-01-13 17:18:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1579743002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1579743002/100001

[nednguyen, 2016-01-13 17:19:19]

https://codereview.chromium.org/1579743002/diff/80001/tools/perf/chrome_telem...
File tools/perf/chrome_telemetry_build/chromium_config.py (right):

https://codereview.chromium.org/1579743002/diff/80001/tools/perf/chrome_telem...
tools/perf/chrome_telemetry_build/chromium_config.py:12:
os.path.join(os.path.dirname(__file__), '..', '..', '..'))
On 2016/01/13 12:34:37, M-A Ruel wrote:
> always use .os.path.abspath(__file__) instead of __file__, otherwise it is not
> OS.chdir() safe which defeats the point.

Done.

https://codereview.chromium.org/1579743002/diff/80001/tools/perf/core/path_ut...
File tools/perf/core/path_util.py (right):

https://codereview.chromium.org/1579743002/diff/80001/tools/perf/core/path_ut...
tools/perf/core/path_util.py:8: sys.path.insert(1,
os.path.join(os.path.dirname(__file__), '..'))
On 2016/01/13 12:34:37, M-A Ruel wrote:
> same

Done.

[commit-bot: I haz the power, 2016-01-13 18:32:00]

Description was changed from

==========
[Telemetry] Update telemetry_unittests to use tools/perf/run_telemetry_tests

BUG=575711,
==========

to

==========
[Telemetry] Update telemetry_unittests to use tools/perf/run_telemetry_tests

BUG=575711,
==========

[commit-bot: I haz the power, 2016-01-13 18:32:00]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-01-13 18:33:10]

Description was changed from

==========
[Telemetry] Update telemetry_unittests to use tools/perf/run_telemetry_tests

BUG=575711,
==========

to

==========
[Telemetry] Update telemetry_unittests to use tools/perf/run_telemetry_tests

BUG=575711,

Committed: https://crrev.com/a9191918994fcda4c8128cde6c1925066df2f08b
Cr-Commit-Position: refs/heads/master@{#369220}
==========

[commit-bot: I haz the power, 2016-01-13 18:33:11]

Patchset 5 (id:??) landed as
https://crrev.com/a9191918994fcda4c8128cde6c1925066df2f08b
Cr-Commit-Position: refs/heads/master@{#369220}