tools/perf/run_telemetry_tests - Issue 1579743002: [Telemetry] Update telemetry_unittests to use tools/perf/run_telemetry_tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/run_telemetry_tests

Issue 1579743002: [Telemetry] Update telemetry_unittests to use tools/perf/run_telemetry_tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 #!/usr/bin/env python	1 #!/usr/bin/env python

2 # Copyright 2013 The Chromium Authors. All rights reserved.	2 # Copyright 2015 The Chromium Authors. All rights reserved.

3 # Use of this source code is governed by a BSD-style license that can be	3 # Use of this source code is governed by a BSD-style license that can be

4 # found in the LICENSE file.	4 # found in the LICENSE file.

5	5

6 """This script runs unit tests of the code in the perf directory.	6 """This script runs unit tests of the code in the perf directory.

7	7

8 This script DOES NOT run benchmarks. run_benchmark does that.	8 This script DOES NOT run benchmarks. run_benchmark does that.

9 """	9 """

10	10

11 import os	11 import os

12 import subprocess	12 import subprocess

13 import sys	13 import sys

14	14

15 from chrome_telemetry_build import chromium_config	15 from chrome_telemetry_build import chromium_config

16 from core import path_util

17	16

18 sys.path.append(path_util.GetTelemetryDir())	17 _TELEMETRY_DIR = os.path.join(os.path.dirname(__file__), '..', 'telemetry')
	aiolos (Not reviewing) 2016/01/11 21:58:45 Why aren't you using the path_util.GetTelemetryDir Why aren't you using the path_util.GetTelemetryDir here? This adds one more location to update when we move telemetry. nednguyen 2016/01/11 22:25:21 Done. Also filed crbug.com/576414 Show quoted text On 2016/01/11 21:58:45, aiolos wrote: > Why aren't you using the path_util.GetTelemetryDir here? This adds one more > location to update when we move telemetry. Done. Also filed crbug.com/576414
	18

	19 sys.path.append(_TELEMETRY_DIR)

19 from telemetry.testing import unittest_runner	20 from telemetry.testing import unittest_runner

20	21

21 def main():	22 def main():

22 project_config = chromium_config.ChromiumConfig()	23 project_config = chromium_config.ChromiumConfig(

	24 _TELEMETRY_DIR)
	aiolos (Not reviewing) 2016/01/11 21:58:45 should this be top_level_dir=_TELEMETRY_DIR instea should this be top_level_dir=_TELEMETRY_DIR instead? nednguyen 2016/01/11 22:25:21 Done. Show quoted text On 2016/01/11 21:58:45, aiolos wrote: > should this be top_level_dir=_TELEMETRY_DIR instead? Done.
23 return unittest_runner.Run(project_config)	25 return unittest_runner.Run(project_config)

24	26

25 if __name__ == '__main__':	27 if __name__ == '__main__':

26 sys.exit(main())	28 sys.exit(main())

OLD	NEW

« no previous file with comments | « testing/buildbot/gn_isolate_map.pyl ('k') | no next file » | no next file with comments »