Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1579663002: Cache values of fields and lists in summary implementations. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cache values of fields and lists in summary implementations. This significantly improves analysis time of a trivial HTML app. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/65f1aa1ef09e04c14a072d36254ccdc202df939e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+885 lines, -284 lines) Patch
M pkg/analyzer/lib/src/summary/flat_buffers.dart View 2 chunks +13 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 48 chunks +788 lines, -216 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +1 line, -0 lines 1 comment Download
M pkg/analyzer/test/src/summary/flat_buffers_test.dart View 3 chunks +19 lines, -15 lines 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 4 chunks +64 lines, -47 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 11 months ago (2016-01-11 17:05:12 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/1579663002/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart File pkg/analyzer/lib/src/summary/resynthesize.dart (right): https://codereview.chromium.org/1579663002/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart#newcode115 pkg/analyzer/lib/src/summary/resynthesize.dart:115: print('getLibraryElement: $uri'); Looks like temporary debugging code that ...
4 years, 11 months ago (2016-01-11 17:12:21 UTC) #2
scheglov
4 years, 11 months ago (2016-01-11 17:29:28 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
65f1aa1ef09e04c14a072d36254ccdc202df939e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698