Cache values of fields and lists in summary implementations.

pkg/analyzer/test/src/summary/flat_buffers_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.src.summary.flat_buffers_test;
 
 import 'package:analyzer/src/summary/flat_buffers.dart';
 import 'package:unittest/unittest.dart';
 
 import '../../reflective_tests.dart';
@@ skipping 131 matching lines @@
         builder.addInt32(0, 100);
         builder.addInt32(1, 200);
         object2 = builder.endTable();
       }
       // write the list
       Offset offset = builder.writeList([object1, object2]);
       byteList = builder.finish(offset);
     }
     // read and verify
     BufferPointer root = new BufferPointer.fromBytes(byteList);
-    List<TestPointReader> items =
-        const ListReader<TestPointReader>(const TestPointReader()).read(root);
+    List<TestPointImpl> items =
+        const ListReader<TestPointImpl>(const TestPointReader()).read(root);
     expect(items, hasLength(2));
     expect(items[0].x, 10);
     expect(items[0].y, 20);
     expect(items[1].x, 100);
     expect(items[1].y, 200);
   }
 
   void test_writeList_ofStrings_asRoot() {
     List<int> byteList;
     {
@@ skipping 18 matching lines @@
       Builder builder = new Builder(initialSize: 0);
       Offset listOffset = builder.writeList(
           [builder.writeString('12345'), builder.writeString('ABC')]);
       builder.startTable();
       builder.addOffset(0, listOffset);
       Offset offset = builder.endTable();
       byteList = builder.finish(offset);
     }
     // read and verify
     BufferPointer root = new BufferPointer.fromBytes(byteList);
-    StringListWrapperReader reader = new StringListWrapperReader().read(root);
+    StringListWrapperImpl reader = new StringListWrapperReader().read(root);
     List<String> items = reader.items;
     expect(items, hasLength(2));
     expect(items, contains('12345'));
     expect(items, contains('ABC'));
   }
 }
 
-class StringListWrapperReader extends TableReader<StringListWrapperReader> {
+class StringListWrapperImpl {
   final BufferPointer bp;
 
-  const StringListWrapperReader() : bp = null;
-
-  StringListWrapperReader._(this.bp);
+  StringListWrapperImpl(this.bp);
 
   List<String> get items =>
       const ListReader<String>(const StringReader()).vTableGet(bp, 0);
+}
+
+class StringListWrapperReader extends TableReader<StringListWrapperImpl> {
+  const StringListWrapperReader();
 
   @override
-  StringListWrapperReader createReader(BufferPointer object) {
-    return new StringListWrapperReader._(object);
+  StringListWrapperImpl createObject(BufferPointer object) {
+    return new StringListWrapperImpl(object);
   }
 }
 
-class TestPointReader extends TableReader<TestPointReader> {
+class TestPointImpl {
   final BufferPointer bp;
 
-  const TestPointReader() : bp = null;
-
-  TestPointReader._(this.bp);
+  TestPointImpl(this.bp);
 
   int get x => const Int32Reader().vTableGet(bp, 0, 0);
 
   int get y => const Int32Reader().vTableGet(bp, 1, 0);
+}
+
+class TestPointReader extends TableReader<TestPointImpl> {
+  const TestPointReader();
 
   @override
-  TestPointReader createReader(BufferPointer object) {
-    return new TestPointReader._(object);
+  TestPointImpl createObject(BufferPointer object) {
+    return new TestPointImpl(object);
   }
 }